New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put hex-encoded version in UpdateTip #7763

Merged
merged 1 commit into from Mar 31, 2016

Conversation

Projects
None yet
6 participants
@sipa
Member

sipa commented Mar 29, 2016

... and also remove the hardly-readable nBits from UpdateTip's log message.

The decimal printing of block nVersion is not very readable in a versionbits world.

@jonasschnelli jonasschnelli added the Docs label Mar 29, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 29, 2016

Member

Maybe %08x?

Member

laanwj commented Mar 29, 2016

Maybe %08x?

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 29, 2016

Member

Updated to use version=0x%08x

Member

sipa commented Mar 29, 2016

Updated to use version=0x%08x

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Mar 29, 2016

Member

utACK b738799

Member

laanwj commented Mar 29, 2016

utACK b738799

@sipa sipa changed the title from Reformat version in UpdateTip and other messages to Put hex-encoded version in UpdateTip Mar 29, 2016

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 29, 2016

Member

Renamed the pull request, as I noticed it wasn't accurate: there was no nVersion in that message before

Member

sipa commented Mar 29, 2016

Renamed the pull request, as I noticed it wasn't accurate: there was no nVersion in that message before

@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd Mar 30, 2016

Contributor

utACK b738799

Contributor

petertodd commented Mar 30, 2016

utACK b738799

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Mar 30, 2016

Member

Nice.
utACK b73879958edcbf964f87fcab1384c04deafa9c6a

Member

jonasschnelli commented Mar 30, 2016

Nice.
utACK b73879958edcbf964f87fcab1384c04deafa9c6a

@paveljanik

View changes

Show outdated Hide outdated src/main.cpp
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 30, 2016

Contributor

ACK b738799

Before:

2016-03-30 13:05:47 UpdateTip: new best=00000000001880d1d2e6c6f340df9f2e317c3a04ae1e22b816113882936ed457  height=752296 bits=457179072 log2_work=67.118529  tx=9847921  date=2016-03-30 06:26:43 progress=0.999992  cache=0.0MiB(22tx)

after:

2016-03-30 13:06:37 UpdateTip: new best=00000000002b58079cfb57b2fc41e677238488c6808f630af8c694053dc8ced8 height=752620 version=0x04 log2_work=67.118541 tx=9851627 date='2016-03-30 10:17:49' progress=0.999996 cache=0.2MiB(1166tx)
Contributor

paveljanik commented Mar 30, 2016

ACK b738799

Before:

2016-03-30 13:05:47 UpdateTip: new best=00000000001880d1d2e6c6f340df9f2e317c3a04ae1e22b816113882936ed457  height=752296 bits=457179072 log2_work=67.118529  tx=9847921  date=2016-03-30 06:26:43 progress=0.999992  cache=0.0MiB(22tx)

after:

2016-03-30 13:06:37 UpdateTip: new best=00000000002b58079cfb57b2fc41e677238488c6808f630af8c694053dc8ced8 height=752620 version=0x04 log2_work=67.118541 tx=9851627 date='2016-03-30 10:17:49' progress=0.999996 cache=0.2MiB(1166tx)
@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens Mar 31, 2016

Contributor

concept ACK, utACK b738799

Contributor

dcousens commented Mar 31, 2016

concept ACK, utACK b738799

Reformat version in UpdateTip and other messages
Also remove the hardly-readable nBits from UpdateTip's log message.
@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Mar 31, 2016

Member

Fixed 0x%02x -> 0x%08x.

Member

sipa commented Mar 31, 2016

Fixed 0x%02x -> 0x%08x.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Mar 31, 2016

Contributor

reACK eff736e

Contributor

paveljanik commented Mar 31, 2016

reACK eff736e

@laanwj laanwj merged commit eff736e into bitcoin:master Mar 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 31, 2016

Merge #7763: Put hex-encoded version in UpdateTip
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7763: Put hex-encoded version in UpdateTip
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7763: Put hex-encoded version in UpdateTip
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7763: Put hex-encoded version in UpdateTip
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7763: Put hex-encoded version in UpdateTip
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7763: Put hex-encoded version in UpdateTip
eff736e Reformat version in UpdateTip and other messages (Pieter Wuille)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment