New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: change Precise to Trusty in gitian-building.md #7791

Merged
merged 1 commit into from Apr 5, 2016

Conversation

Projects
None yet
7 participants
@JeremyRand
Contributor

JeremyRand commented Apr 2, 2016

2cecb24 changed "precise" to "trusty" in the shell command, but didn't change the text above it accordingly. This commit fixes that.

Doc: change Precise to Trusty in gitian-building.md
2cecb24 changed "precise" to "trusty" in the shell command, but didn't change the text above it accordingly.  This commit fixes that.
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake
Member

fanquake commented Apr 3, 2016

ACK 190c1e2

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented Apr 3, 2016

ACK 190c1e2

@jonasschnelli jonasschnelli added the Docs label Apr 3, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 3, 2016

Member

There are various references to precise in doc/gitian-building.md as well, may be good to change them at the same time.

Member

laanwj commented Apr 3, 2016

There are various references to precise in doc/gitian-building.md as well, may be good to change them at the same time.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 3, 2016

Member

good to change them at the same time.

Or remove them (replace with something general) so they never need to be changed again.

Member

MarcoFalke commented Apr 3, 2016

good to change them at the same time.

Or remove them (replace with something general) so they never need to be changed again.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 3, 2016

Member

Or remove them (replace with something general) so they never need to be changed again.

As parts of those are part of commands that have to be executed literally that's much more work, I don't think we can ask that of the OP.

Member

laanwj commented Apr 3, 2016

Or remove them (replace with something general) so they never need to be changed again.

As parts of those are part of commands that have to be executed literally that's much more work, I don't think we can ask that of the OP.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 3, 2016

Member

Oh, all of them are part of a command, so what I said does not apply to this particular pull. ☁️

Member

MarcoFalke commented Apr 3, 2016

Oh, all of them are part of a command, so what I said does not apply to this particular pull. ☁️

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 4, 2016

Contributor

ACK 190c1e2

Contributor

paveljanik commented Apr 4, 2016

ACK 190c1e2

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak
Member

btcdrak commented Apr 5, 2016

ACK 190c1e2

@laanwj laanwj merged commit 190c1e2 into bitcoin:master Apr 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 5, 2016

Merge #7791: Doc: change Precise to Trusty in gitian-building.md
190c1e2 Doc: change Precise to Trusty in gitian-building.md (JeremyRand)

@JeremyRand JeremyRand deleted the JeremyRand:patch-1 branch Apr 11, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7791: Doc: change Precise to Trusty in gitian-building.md
190c1e2 Doc: change Precise to Trusty in gitian-building.md (JeremyRand)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7791: Doc: change Precise to Trusty in gitian-building.md
190c1e2 Doc: change Precise to Trusty in gitian-building.md (JeremyRand)

codablock added a commit to codablock/dash that referenced this pull request Dec 9, 2017

Merge #7791: Doc: change Precise to Trusty in gitian-building.md
190c1e2 Doc: change Precise to Trusty in gitian-building.md (JeremyRand)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7791: Doc: change Precise to Trusty in gitian-building.md
190c1e2 Doc: change Precise to Trusty in gitian-building.md (JeremyRand)

codablock added a commit to codablock/dash that referenced this pull request Dec 19, 2017

Merge #7791: Doc: change Precise to Trusty in gitian-building.md
190c1e2 Doc: change Precise to Trusty in gitian-building.md (JeremyRand)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment