New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[travis] Print the commit which was evaluated #7798

Merged
merged 2 commits into from Apr 15, 2016

Conversation

Projects
None yet
5 participants
@MarcoFalke
Member

MarcoFalke commented Apr 3, 2016

The travis test result which is linked to by most commits on GitHub is sometimes not related to the commit.

It may happen that even the build jobs of a single build contains results from different commits.

@laanwj laanwj added the Tests label Apr 3, 2016

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Apr 5, 2016

Member

Travis error seems unrelated. Just re-kicked travis for this PR.

Member

jonasschnelli commented Apr 5, 2016

Travis error seems unrelated. Just re-kicked travis for this PR.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Apr 5, 2016

Member

Maybe you'd like to print $TRAVIS_COMMIT_RANGE, so that it's immediately clear what was in the build? I believe it should print "foo...bar", which could be easily checked locally.

Member

theuni commented Apr 5, 2016

Maybe you'd like to print $TRAVIS_COMMIT_RANGE, so that it's immediately clear what was in the build? I believe it should print "foo...bar", which could be easily checked locally.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 5, 2016

Member

Right now it should print

commit $some_random_hash Merge: 30c2dd8 faef3b7

where 30c2dd8 should be in bitcoin/master and faef3b7 in the branch someone wants to merge. I think that is sufficient to quickly check that something went wrong.

Member

MarcoFalke commented Apr 5, 2016

Right now it should print

commit $some_random_hash Merge: 30c2dd8 faef3b7

where 30c2dd8 should be in bitcoin/master and faef3b7 in the branch someone wants to merge. I think that is sufficient to quickly check that something went wrong.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 5, 2016

Member

Travis error seems unrelated

Travis is building random crap, which you can see by observing the commit ids:

$ echo $TRAVIS_COMMIT_LOG
commit 73c560fc0d92177e88ddd02f6ac628340b85688c Merge: 30c2dd8 4b1ea9a

where 30c2dd8 is the current HEAD and 4b1ea9a is some random commit.

So the travis error is "related" but unwanted.

Member

MarcoFalke commented Apr 5, 2016

Travis error seems unrelated

Travis is building random crap, which you can see by observing the commit ids:

$ echo $TRAVIS_COMMIT_LOG
commit 73c560fc0d92177e88ddd02f6ac628340b85688c Merge: 30c2dd8 4b1ea9a

where 30c2dd8 is the current HEAD and 4b1ea9a is some random commit.

So the travis error is "related" but unwanted.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 5, 2016

Member

@theuni Is it ok if I print both, so it is clear which commit of the target branch travis used? Also, I'd rather not trust $TRAVIS_COMMIT_RANGE blindly.

$ echo $TRAVIS_COMMIT_RANGE
30c2dd8d0598afac9319d3a813a89a682b9c0d34...fac9ca2ec69bc629dbbd81c83e5bf67690e52c96
$ echo $TRAVIS_COMMIT_LOG
commit 049d5e4dfe711bb2af5c9c3904de7f78a24fedac Merge: a914968 fac9ca2
Member

MarcoFalke commented Apr 5, 2016

@theuni Is it ok if I print both, so it is clear which commit of the target branch travis used? Also, I'd rather not trust $TRAVIS_COMMIT_RANGE blindly.

$ echo $TRAVIS_COMMIT_RANGE
30c2dd8d0598afac9319d3a813a89a682b9c0d34...fac9ca2ec69bc629dbbd81c83e5bf67690e52c96
$ echo $TRAVIS_COMMIT_LOG
commit 049d5e4dfe711bb2af5c9c3904de7f78a24fedac Merge: a914968 fac9ca2
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 9, 2016

Member

Last travis failure indeed unrelated:

Failed to fetch http://us.archive.ubuntu.com/ubuntu/pool/main/g/gcc-4.6/libstdc++6_4.6.3-1ubuntu5_i386.deb  Unable to connect to us.archive.ubuntu.com:http: [IP: 2001:67c:1562::15 80]

Anything holding this back?

Member

MarcoFalke commented Apr 9, 2016

Last travis failure indeed unrelated:

Failed to fetch http://us.archive.ubuntu.com/ubuntu/pool/main/g/gcc-4.6/libstdc++6_4.6.3-1ubuntu5_i386.deb  Unable to connect to us.archive.ubuntu.com:http: [IP: 2001:67c:1562::15 80]

Anything holding this back?

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Apr 9, 2016

Member

Restarting travis.

Member

sipa commented Apr 9, 2016

Restarting travis.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Apr 12, 2016

Member

utACK

Member

sipa commented Apr 12, 2016

utACK

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Apr 12, 2016

Member

utACK fac9ca2

Member

theuni commented Apr 12, 2016

utACK fac9ca2

@laanwj laanwj merged commit fac9ca2 into bitcoin:master Apr 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 15, 2016

Merge #7798: [travis] Print the commit which was evaluated
fac9ca2 [travis] echo $TRAVIS_COMMIT_RANGE (MarcoFalke)
faef3b7 [travis] Print the commit which was evaluated (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1604-travisCommitLog branch Apr 15, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge bitcoin#7798: [travis] Print the commit which was evaluated
fac9ca2 [travis] echo $TRAVIS_COMMIT_RANGE (MarcoFalke)
faef3b7 [travis] Print the commit which was evaluated (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#7798: [travis] Print the commit which was evaluated
fac9ca2 [travis] echo $TRAVIS_COMMIT_RANGE (MarcoFalke)
faef3b7 [travis] Print the commit which was evaluated (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 20, 2017

Merge bitcoin#7798: [travis] Print the commit which was evaluated
fac9ca2 [travis] echo $TRAVIS_COMMIT_RANGE (MarcoFalke)
faef3b7 [travis] Print the commit which was evaluated (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment