Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[qa] Remove misleading "errorString syntax" #7801

Merged
merged 1 commit into from Apr 6, 2016

Conversation

Projects
None yet
3 participants
Member

MarcoFalke commented Apr 3, 2016

Personally, I find the errorString "syntax" to "see" when an exception happens confusing. It is error prone in the best case.

Imo, valid syntax is either

try:
  something()
  assert(False)
except:
  assert(thing())

or

try:
  something()
except:
  assert(thing())
else:
  assert(False)

@jonasschnelli jonasschnelli added the Tests label Apr 4, 2016

Owner

laanwj commented Apr 6, 2016

ACK ffff866

@laanwj laanwj merged commit ffff866 into bitcoin:master Apr 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 6, 2016

Merge #7801: [qa] Remove misleading "errorString syntax"
ffff866 [qa] Remove misleading "errorString syntax" (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1604-qaTestErrorString branch Apr 6, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Apr 19, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 11, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request Nov 14, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7801: [qa] Remove misleading "errorString syntax"
ffff866 [qa] Remove misleading "errorString syntax" (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7801: [qa] Remove misleading "errorString syntax"
ffff866 [qa] Remove misleading "errorString syntax" (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment