New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] httpbasics: Actually test second connection #7802

Merged
merged 1 commit into from Apr 6, 2016

Conversation

Projects
None yet
4 participants
@MarcoFalke
Member

MarcoFalke commented Apr 3, 2016

Currently the test will always return Tests successful. 馃寶

(As I am touching this file, I have also marked some byte strings as byte strings explicitly, which is a noop for py2, but helps switching to py3)

@jonasschnelli jonasschnelli added the Tests label Apr 4, 2016

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 5, 2016

Contributor

It would be easier to review when separated to two commits.

Contributor

paveljanik commented Apr 5, 2016

It would be easier to review when separated to two commits.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 5, 2016

Member

@paveljanik The bugfix is visible on two lines: s/out2/out1/g. If you still want me to split, I am happy to do so.

Member

MarcoFalke commented Apr 5, 2016

@paveljanik The bugfix is visible on two lines: s/out2/out1/g. If you still want me to split, I am happy to do so.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 5, 2016

Contributor

No need to do that here (it is very simple fix). I did this for the review myself.

ACK fa24456

Contributor

paveljanik commented Apr 5, 2016

No need to do that here (it is very simple fix). I did this for the review myself.

ACK fa24456

@laanwj laanwj merged commit fa24456 into bitcoin:master Apr 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 6, 2016

Merge #7802: [qa] httpbasics: Actually test second connection
fa24456 [qa] httpbasics: Actually test second connection (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1604-qaTestHttp branch Apr 6, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jun 9, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

@str4d str4d referenced this pull request Jul 11, 2017

Merged

pyflakes cleanup #2458

zkbot added a commit to zcash/zcash that referenced this pull request Jul 15, 2017

Auto merge of #2458 - daira:2450.pyflakes-cleanup, r=str4d
pyflakes cleanup

Make the RPC tests pyflakes-clean. fixes #2450

Includes a fix that upstream had in bitcoin/bitcoin#7802

@dagurval dagurval referenced this pull request Jan 28, 2018

Merged

HTTP Server cherries #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment