New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed miner test values, gave constants for less error-prone values. #7807

Merged
merged 2 commits into from Apr 29, 2016

Conversation

Projects
None yet
6 participants
@instagibbs
Member

instagibbs commented Apr 4, 2016

Based on discussion in #7784 I decided to do a bit more cleanup.

@instagibbs

This comment has been minimized.

Show comment
Hide comment
@instagibbs

instagibbs Apr 4, 2016

Member

Doing this I noticed yet another mis-typed value on https://github.com/bitcoin/bitcoin/pull/7807/files#diff-5c64500485fda76388a86c95c0059585L173 , so it seemed worthwhile.

Member

instagibbs commented Apr 4, 2016

Doing this I noticed yet another mis-typed value on https://github.com/bitcoin/bitcoin/pull/7807/files#diff-5c64500485fda76388a86c95c0059585L173 , so it seemed worthwhile.

@jonasschnelli jonasschnelli added the Tests label Apr 4, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 4, 2016

Member

That's clearer. Concept ACK 11679ca

Member

MarcoFalke commented Apr 4, 2016

That's clearer. Concept ACK 11679ca

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 5, 2016

Member

utACK

Member

laanwj commented Apr 5, 2016

utACK

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Apr 5, 2016

Member

utACK

Member

btcdrak commented Apr 5, 2016

utACK

for (unsigned int i = 0; i < 128; ++i)
{
tx.vout[0].nValue -= 10000000;

This comment has been minimized.

@paveljanik

paveljanik Apr 6, 2016

Contributor

10*LOWFEE?

@paveljanik

paveljanik Apr 6, 2016

Contributor

10*LOWFEE?

@@ -211,7 +216,7 @@ BOOST_AUTO_TEST_CASE(CreateNewBlock_validity)
tx.vout[0].nValue = 0;
hash = tx.GetHash();
// give it a fee so it'll get mined
mempool.addUnchecked(hash, entry.Fee(100000).Time(GetTime()).SpendsCoinbase(false).FromTx(tx));

This comment has been minimized.

@paveljanik

paveljanik Apr 6, 2016

Contributor

LOWFEE/10?

@paveljanik

paveljanik Apr 6, 2016

Contributor

LOWFEE/10?

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 6, 2016

Contributor

As you are not replacing constants only, can you please change it so that you first replace constants unchanged and then do the changes, ie two commits? It will make review much easier...

Contributor

paveljanik commented Apr 6, 2016

As you are not replacing constants only, can you please change it so that you first replace constants unchanged and then do the changes, ie two commits? It will make review much easier...

@instagibbs

This comment has been minimized.

Show comment
Hide comment
@instagibbs
Member

instagibbs commented Apr 6, 2016

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 7, 2016

Contributor

@instagibbs Reading this thoroughly, I think we could also define constants in the term of COIN and CENT, it could be even more descriptive.

Contributor

paveljanik commented Apr 7, 2016

@instagibbs Reading this thoroughly, I think we could also define constants in the term of COIN and CENT, it could be even more descriptive.

@MarcoFalke MarcoFalke merged commit f8536a6 into bitcoin:master Apr 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Apr 29, 2016

Merge #7807: Fixed miner test values, gave constants for less error-p…
…rone values.

f8536a6 Corrected values (instagibbs)
617deeb Gave miner test values constants for less error-prone values. (instagibbs)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7807: Fixed miner test values, gave constants for less error-p…
…rone values.

f8536a6 Corrected values (instagibbs)
617deeb Gave miner test values constants for less error-prone values. (instagibbs)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7807: Fixed miner test values, gave constants for less error-p…
…rone values.

f8536a6 Corrected values (instagibbs)
617deeb Gave miner test values constants for less error-prone values. (instagibbs)

codablock added a commit to codablock/dash that referenced this pull request Dec 20, 2017

Merge #7807: Fixed miner test values, gave constants for less error-p…
…rone values.

f8536a6 Corrected values (instagibbs)
617deeb Gave miner test values constants for less error-prone values. (instagibbs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment