New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Switch to py3 #7814

Merged
merged 1 commit into from May 6, 2016

Conversation

Projects
None yet
3 participants
@MarcoFalke
Member

MarcoFalke commented Apr 5, 2016

Blockers:

  • #7893 (figure out fix for bctest.py on precise) OR #7920 (bump to trusty)

@laanwj laanwj added the Tests label Apr 5, 2016

@laanwj laanwj changed the title from [qa] Switch to py3 to [WIP] [qa] Switch to py3 Apr 6, 2016

@MarcoFalke MarcoFalke changed the title from [WIP] [qa] Switch to py3 to [qa] Switch to py3 Apr 27, 2016

@MarcoFalke MarcoFalke changed the title from [qa] Switch to py3 to [WIP] [qa] Switch to py3 Apr 27, 2016

@laanwj laanwj referenced this pull request Apr 28, 2016

Closed

TODO for release notes 0.13.0 #7678

14 of 16 tasks complete

@MarcoFalke MarcoFalke changed the title from [WIP] [qa] Switch to py3 to [qa] Switch to py3 Apr 30, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 2, 2016

Member

Tested ACK e5dac45

Member

laanwj commented May 2, 2016

Tested ACK e5dac45

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 3, 2016

Member

Rebased

Member

MarcoFalke commented May 3, 2016

Rebased

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 4, 2016

Member

I've been testing this on fedora linux. Would be good to know if this also works on osx and win. (If you want to test this, there is no need to compile anything. Just fetch the commit and run it through the test suite.)

Member

MarcoFalke commented May 4, 2016

I've been testing this on fedora linux. Would be good to know if this also works on osx and win. (If you want to test this, there is no need to compile anything. Just fetch the commit and run it through the test suite.)

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 4, 2016

Member

Run through the short test suite on OSX 10.11, all tests passed. Can we add a line for the zeromq osx dependancy?

pip3 install pyzmq was what I needed to get it working.

Member

fanquake commented May 4, 2016

Run through the short test suite on OSX 10.11, all tests passed. Can we add a line for the zeromq osx dependancy?

pip3 install pyzmq was what I needed to get it working.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 5, 2016

Member

I've tested both the extended and short test suite on Ubuntu 14.04. This passes.
Going to test on Debian 8.4 and Ubuntu 16.04 next.

Member

laanwj commented May 5, 2016

I've tested both the extended and short test suite on Ubuntu 14.04. This passes.
Going to test on Debian 8.4 and Ubuntu 16.04 next.

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 5, 2016

Member

Running through the extended test suite.

Running testscript signmessages.py ...
Initializing test directory /var/folders/rb/jqqd25w926s5429rf58_zsv00000gn/T/testim6xak
JSONRPC error: Method not found
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 135, in main
    self.run_test()
  File "/Users/michael/github/bitcoin/qa/rpc-tests/signmessages.py", line 27, in run_test
    signature = self.nodes[0].signmessagewithprivkey(privKey, message)
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/coverage.py", line 49, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 139, in __call__
    raise JSONRPCException(response['error'])
Stopping nodes
Cleaning up
Failed
Traceback (most recent call last):
  File "qa/pull-tester/rpc-tests.py", line 275, in <module>
    runtests()
  File "qa/pull-tester/rpc-tests.py", line 178, in runtests
    rpcTestDir + testScripts[i] + flags, shell=True)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/subprocess.py", line 584, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '/Users/michael/github/bitcoin/qa/rpc-tests/signmessages.py --srcdir /Users/michael/github/bitcoin/src  ' returned non-zero exit status 1

Looks like signmessages.py has been missed, as it also still has env/ python2

Member

fanquake commented May 5, 2016

Running through the extended test suite.

Running testscript signmessages.py ...
Initializing test directory /var/folders/rb/jqqd25w926s5429rf58_zsv00000gn/T/testim6xak
JSONRPC error: Method not found
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 135, in main
    self.run_test()
  File "/Users/michael/github/bitcoin/qa/rpc-tests/signmessages.py", line 27, in run_test
    signature = self.nodes[0].signmessagewithprivkey(privKey, message)
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/coverage.py", line 49, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
  File "/Users/michael/Github/bitcoin/qa/rpc-tests/test_framework/authproxy.py", line 139, in __call__
    raise JSONRPCException(response['error'])
Stopping nodes
Cleaning up
Failed
Traceback (most recent call last):
  File "qa/pull-tester/rpc-tests.py", line 275, in <module>
    runtests()
  File "qa/pull-tester/rpc-tests.py", line 178, in runtests
    rpcTestDir + testScripts[i] + flags, shell=True)
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/subprocess.py", line 584, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '/Users/michael/github/bitcoin/qa/rpc-tests/signmessages.py --srcdir /Users/michael/github/bitcoin/src  ' returned non-zero exit status 1

Looks like signmessages.py has been missed, as it also still has env/ python2

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 5, 2016

Member

Ah yes - merging a pull that adds a new test wasn't a very good idea. Now this probably needs to be updated to include the new test, otherwise it can't be merged without breaking travis.

Member

laanwj commented May 5, 2016

Ah yes - merging a pull that adds a new test wasn't a very good idea. Now this probably needs to be updated to include the new test, otherwise it can't be merged without breaking travis.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 5, 2016

Member

JSONRPC error: Method not found

Na, you just need to compile the new signmessage code.

Rebased nonetheless.

Member

MarcoFalke commented May 5, 2016

JSONRPC error: Method not found

Na, you just need to compile the new signmessage code.

Rebased nonetheless.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 5, 2016

Member

Interesting that this makes the test slower, though:

py3:

$ ./qa/pull-tester/rpc-tests.py signmessages
Running testscript signmessages.py ...
Initializing test directory /tmp/testgxs02bu5
Stopping nodes
Cleaning up
Tests successful
Duration: 2 s

py2:

$ ./qa/pull-tester/rpc-tests.py signmessages
Running testscript signmessages.py ...
Initializing test directory /tmp/testXaAvpQ
Stopping nodes
Cleaning up
Tests successful
Duration: 0 s

wait_bitcoinds() takes 2 seconds now.

Member

MarcoFalke commented May 5, 2016

Interesting that this makes the test slower, though:

py3:

$ ./qa/pull-tester/rpc-tests.py signmessages
Running testscript signmessages.py ...
Initializing test directory /tmp/testgxs02bu5
Stopping nodes
Cleaning up
Tests successful
Duration: 2 s

py2:

$ ./qa/pull-tester/rpc-tests.py signmessages
Running testscript signmessages.py ...
Initializing test directory /tmp/testXaAvpQ
Stopping nodes
Cleaning up
Tests successful
Duration: 0 s

wait_bitcoinds() takes 2 seconds now.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 5, 2016

Member

Strange.

Member

laanwj commented May 5, 2016

Strange.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 6, 2016

Member

Indeed interesting; Other test still run fast with py3:

$ qa/pull-tester/rpc-tests.py disablewallet
Running testscript disablewallet.py ...
Initializing test directory /tmp/test_zgnh7e3
Stopping nodes
Cleaning up
Tests successful
Duration: 0 s

But let's not worry about it too much, this will be compensated by #7972, hopefully.

Member

MarcoFalke commented May 6, 2016

Indeed interesting; Other test still run fast with py3:

$ qa/pull-tester/rpc-tests.py disablewallet
Running testscript disablewallet.py ...
Initializing test directory /tmp/test_zgnh7e3
Stopping nodes
Cleaning up
Tests successful
Duration: 0 s

But let's not worry about it too much, this will be compensated by #7972, hopefully.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 6, 2016

Member

Right, well if it is two seconds on one test I don't see why it would need to be a blocker.

Member

laanwj commented May 6, 2016

Right, well if it is two seconds on one test I don't see why it would need to be a blocker.

@laanwj laanwj merged commit fa389d4 into bitcoin:master May 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 6, 2016

Merge #7814: [qa] Switch to py3
fa389d4 [qa] Switch to py3 (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1604-qaPy3 branch May 6, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jul 15, 2016

[qa] Switch to py3
Github-Pull: #7814
Rebased-From: fa389d4

UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Mar 22, 2017

Switch to py3
Github-Pull: #7814
Rebased-From: fa389d4

@dagurval dagurval referenced this pull request Aug 29, 2017

Merged

Python 3 for qa #257

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7814: [qa] Switch to py3
fa389d4 [qa] Switch to py3 (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7814: [qa] Switch to py3
fa389d4 [qa] Switch to py3 (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #7814: [qa] Switch to py3
fa389d4 [qa] Switch to py3 (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment