New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: do not print minping time in getpeerinfo when no ping received yet #7842

Merged
merged 1 commit into from Apr 14, 2016

Conversation

Projects
None yet
5 participants
@paveljanik
Contributor

paveljanik commented Apr 8, 2016

When no ping received yet, minping value in getpeerinfo is uninitialized (resp. initialized to std::numeric_limits<int64_t>::max()/1e6). Do not print it in such cases.

Document such behaviour (also for pingwait).

Fixes #7837.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 8, 2016

Member

utACK

Member

MarcoFalke commented Apr 8, 2016

utACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 9, 2016

Member

Just realized: dPingTime suffers from the same problem if there has never been a ping. It gets initialized to zero, but that's just as well a nonsensical value if we really want to be consistent at 'leave out fields that have no value'.

Member

laanwj commented Apr 9, 2016

Just realized: dPingTime suffers from the same problem if there has never been a ping. It gets initialized to zero, but that's just as well a nonsensical value if we really want to be consistent at 'leave out fields that have no value'.

@laanwj laanwj added the RPC/REST/ZMQ label Apr 9, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj
Member

laanwj commented Apr 9, 2016

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 9, 2016

Contributor

Do you want me to change it in one go?

Contributor

paveljanik commented Apr 9, 2016

Do you want me to change it in one go?

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 9, 2016

Member

Do you want me to change it in one go?

I'd say it makes sense, it's basically the same thing.

Member

laanwj commented Apr 9, 2016

Do you want me to change it in one go?

I'd say it makes sense, it's basically the same thing.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 9, 2016

Contributor

Force pushed.

Contributor

paveljanik commented Apr 9, 2016

Force pushed.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 9, 2016

Member

Great!

Member

laanwj commented Apr 9, 2016

Great!

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Apr 9, 2016

utACK 62a6486

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Apr 12, 2016

Member

Concept ACK

Member

sipa commented Apr 12, 2016

Concept ACK

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 14, 2016

Member

Tested ACK. New connection has neither minping, pingtime or pingwait.

[
  {
    "id": 1,
    "addr": "127.0.0.1:56078",
    "services": "0000000000000000",
    "relaytxes": false,
    "lastsend": 0,
    "lastrecv": 0,
    "bytessent": 0,
    "bytesrecv": 0,
    "conntime": 1460642850,
    "timeoffset": 0,
    "version": 0,
    "subver": "",
    "inbound": true,
    "startingheight": -1,
    "banscore": 0,
    "synced_headers": -1,
    "synced_blocks": -1,
    "inflight": [
    ],
    "whitelisted": false,
    "bytessent_per_msg": {
    },
    "bytesrecv_per_msg": {
    }
  }
]
Member

laanwj commented Apr 14, 2016

Tested ACK. New connection has neither minping, pingtime or pingwait.

[
  {
    "id": 1,
    "addr": "127.0.0.1:56078",
    "services": "0000000000000000",
    "relaytxes": false,
    "lastsend": 0,
    "lastrecv": 0,
    "bytessent": 0,
    "bytesrecv": 0,
    "conntime": 1460642850,
    "timeoffset": 0,
    "version": 0,
    "subver": "",
    "inbound": true,
    "startingheight": -1,
    "banscore": 0,
    "synced_headers": -1,
    "synced_blocks": -1,
    "inflight": [
    ],
    "whitelisted": false,
    "bytessent_per_msg": {
    },
    "bytesrecv_per_msg": {
    }
  }
]

@laanwj laanwj merged commit 62a6486 into bitcoin:master Apr 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 14, 2016

Merge #7842: RPC: do not print minping time in getpeerinfo when no pi…
…ng received yet

62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík)
@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Apr 14, 2016

Member

posthumous "hey, I was whining about that" ACK.

Member

gmaxwell commented Apr 14, 2016

posthumous "hey, I was whining about that" ACK.

codablock added a commit to codablock/dash that referenced this pull request Sep 7, 2017

Merge bitcoin#7842: RPC: do not print minping time in getpeerinfo whe…
…n no ping received yet

62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík)

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 9, 2017

Backport Bitcoin Qt/Gui changes up to 0.14.x part 2 (#1615)
* Merge bitcoin#7506: Use CCoinControl selection in CWallet::FundTransaction

d6cc6a1 Use CCoinControl selection in CWallet::FundTransaction (João Barbosa)

* Merge bitcoin#7732: [Qt] Debug window: replace "Build date" with "Datadir"

fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

* Merge bitcoin#7707: [RPC][QT] UI support for abandoned transactions

8efed3b [Qt] Support for abandoned/abandoning transactions (Jonas Schnelli)

* Merge bitcoin#7688: List solvability in listunspent output and improve help

c3932b3 List solvability in listunspent output and improve help (Pieter Wuille)

* Merge bitcoin#8006: Qt: Add option to disable the system tray icon

8b0e497 Qt: Add option to hide the system tray icon (Tyler Hardin)

* Merge bitcoin#8073: qt: askpassphrasedialog: Clear pass fields on accept

02ce2a3 qt: askpassphrasedialog: Clear pass fields on accept (Pavel Vasin)

* Merge bitcoin#8231: [Qt] fix a bug where the SplashScreen will not be hidden during startup

b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli)

* Merge bitcoin#8257: Do not ask a UI question from bitcoind

1acf1db Do not ask a UI question from bitcoind (Pieter Wuille)

* Merge bitcoin#8463: [qt] Remove Priority from coincontrol dialog

fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke)

* Merge bitcoin#8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee

0480293 [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (Jonas Schnelli)

* Merge bitcoin#8672: Qt: Show transaction size in transaction details window

c015634 qt: Adding transaction size to transaction details window (Hampus Sjöberg)
 \-- merge fix for s/size/total size/
fdf82fb Adding method GetTotalSize() to CTransaction (Hampus Sjöberg)

* Merge bitcoin#8371: [Qt] Add out-of-sync modal info layer

08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli)
d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli)
e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli)
e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli)
a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli)
bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli)
0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli)

* Merge bitcoin#8805: Trivial: Grammar and capitalization

c9ce17b Trivial: Grammar and capitalization (Derek Miller)

* Merge bitcoin#8885: gui: fix ban from qt console

cb78c60 gui: fix ban from qt console (Cory Fields)

* Merge bitcoin#8821: [qt] sync-overlay: Don't block during reindex

fa85e86 [qt] sync-overlay: Don't show estimated number of headers left (MarcoFalke)
faa4de2 [qt] sync-overlay: Don't block during reindex (MarcoFalke)

* Support themes for new transaction_abandoned icon

* Fix constructor call to COutput

* Merge bitcoin#7842: RPC: do not print minping time in getpeerinfo when no ping received yet

62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík)

* Merge bitcoin#8918: Qt: Add "Copy URI" to payment request context menu

21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr)

* Merge bitcoin#8925: qt: Display minimum ping in debug window.

1724a40 Display minimum ping in debug window. (R E Broadley)

* Merge bitcoin#8972: [Qt] make warnings label selectable (jonasschnelli)

ef0c9ee [Qt] make warnings label selectable (Jonas Schnelli)

* Make background of warning icon transparent in modaloverlay

* Merge bitcoin#9088: Reduce ambiguity of warning message

77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)

* Replace Bitcoin with Dash in modal overlay

* Remove clicked signals from labelWalletStatus and labelTransactionsStatus

As both are really just labels, clicking on those is not possible.
This is different in Bitcoin, where these labels are actually buttons.

* Pull out modaloverlay show/hide into it's own if/else block and switch to time based check

Also don't use masternodeSync.IsBlockchainSynced() for now as it won't
report the blockchain being synced before the first block (or other MN
data?) arrives. This would otherwise give the impression that sync is
being stuck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment