New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] pull-tester: Don't mute zmq ImportError #7851

Merged
merged 3 commits into from Apr 19, 2016

Conversation

Projects
None yet
2 participants
@MarcoFalke
Member

MarcoFalke commented Apr 9, 2016

Let's consider muting exceptions bad practice. It is good to have a more verbose output, so I left this as is.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 9, 2016

Member

Looks like I need to move some code; use faa4f22?w=0 to check the second diff.

Member

MarcoFalke commented Apr 9, 2016

Looks like I need to move some code; use faa4f22?w=0 to check the second diff.

@laanwj laanwj added the Tests label Apr 11, 2016

if EXEEXT == ".exe" and "-win" not in opts:
print "Win tests currently disabled. Use -win option to enable"
# https://github.com/bitcoin/bitcoin/commit/d52802551752140cf41f0d9a225a43e84404d3e9

This comment has been minimized.

@laanwj

laanwj Apr 14, 2016

Member

Makes sense to refer to the discussion of the pull this was part of: #5677 (comment)

@laanwj

laanwj Apr 14, 2016

Member

Makes sense to refer to the discussion of the pull this was part of: #5677 (comment)

This comment has been minimized.

@MarcoFalke

MarcoFalke Apr 15, 2016

Member

Done

@MarcoFalke

MarcoFalke Apr 15, 2016

Member

Done

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 14, 2016

Member

Concept ACK

Member

laanwj commented Apr 14, 2016

Concept ACK

@MarcoFalke MarcoFalke referenced this pull request Apr 16, 2016

Merged

[qa] Switch to py3 #7814

1 of 1 task complete
@laanwj

View changes

Show outdated Hide outdated qa/pull-tester/rpc-tests.py

@laanwj laanwj merged commit fae1f4e into bitcoin:master Apr 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 19, 2016

Merge #7851: [qa] pull-tester: Don't mute zmq ImportError
fae1f4e [qa] rpc-tests: Fix link in comment and label error msg (MarcoFalke)
faa4f22 [qa] pull-tester: Exit early when no tests are run (MarcoFalke)
fa05e22 [qa] pull-tester: Don't mute zmq ImportError (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1604-qaUnmuteError branch Apr 19, 2016

laanwj added a commit to laanwj/bitcoin that referenced this pull request May 9, 2016

test: Revert fatal-ness of missing python-zmq
It looks like travis is using the `travis.yml` from the branch, but runs
the test script from the branch merged into master. This causes
pull requests created before the QA tests python 3 transition to fail.

This temporarily reverts fa05e22
(bitcoin#7851). It can be restored when this is no longer an issue.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment