New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] bctest.py: Revert faa41ee #7878

Merged
merged 1 commit into from Apr 15, 2016

Conversation

Projects
None yet
4 participants
@MarcoFalke
Member

MarcoFalke commented Apr 14, 2016

Fixes #7853 (comment)

Rationale:

  • The type of input must be bytes or, if universal_newlines was True, a string. [1]
  • universal_newlines is set to True [2]

So this pull reverts to the old behavior of using strings on py3 as well as on py2. No changes to this file were necessary, as it is already compatible. (At this point, I am not sure why I changed this in the first place)

Edit: The reason this went unnoticed on travis was that travis still runs py2.7 but other systems will choose python3 if available since 18f05c7

@mruddy

This comment has been minimized.

Show comment
Hide comment
@mruddy

mruddy Apr 14, 2016

Contributor

ACK
I researched this a little before and came to the same conclusion about universal_newlines. That's what confused me about your initial change. Reassuring that we both came to the same conclusion now. Thanks for the quick fix!

Contributor

mruddy commented Apr 14, 2016

ACK
I researched this a little before and came to the same conclusion about universal_newlines. That's what confused me about your initial change. Reassuring that we both came to the same conclusion now. Thanks for the quick fix!

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 14, 2016

Contributor

ACK fa7abe0

Contributor

paveljanik commented Apr 14, 2016

ACK fa7abe0

@laanwj laanwj added the Tests label Apr 15, 2016

@laanwj laanwj merged commit fa7abe0 into bitcoin:master Apr 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 15, 2016

Merge #7878: [test] bctest.py: Revert faa41ee
fa7abe0 [test] bctest.py: Revert faa41ee (MarcoFalke)
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj
Member

laanwj commented Apr 15, 2016

tACK fa7abe0

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1604-bctestPy branch Apr 15, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7878: [test] bctest.py: Revert faa41ee
fa7abe0 [test] bctest.py: Revert faa41ee (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7878: [test] bctest.py: Revert faa41ee
fa7abe0 [test] bctest.py: Revert faa41ee (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 20, 2017

Merge #7878: [test] bctest.py: Revert faa41ee
fa7abe0 [test] bctest.py: Revert faa41ee (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment