New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release process #7881

Merged
merged 3 commits into from Apr 25, 2016

Conversation

Projects
None yet
4 participants
@laanwj
Member

laanwj commented Apr 15, 2016

The actual release process had quite diverged from what was written here, also clarify things a bit and update the style to be like our other .md files. More like "rewrite the entire thing".

Best to read the rendered version: https://github.com/laanwj/bitcoin/blob/2016_04_update_release_process/doc/release-process.md

Closes #7595 as well by removing the hardcoded version number from verify.sh.

@laanwj laanwj added the Docs label Apr 15, 2016

```
The list of files should be:
```

This comment has been minimized.

@fanquake

fanquake Apr 15, 2016

Member

Should we use {VERSION} here in place of hard coded numbers

@fanquake

fanquake Apr 15, 2016

Member

Should we use {VERSION} here in place of hard coded numbers

This comment has been minimized.

@laanwj

laanwj Apr 15, 2016

Member

Sure!

@laanwj

laanwj Apr 15, 2016

Member

Sure!

@MarcoFalke MarcoFalke referenced this pull request Apr 15, 2016

Closed

[doc] verify.sh #7882

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 15, 2016

Member

Concept ACK. Confirmed changes to verify.sh are working

Member

MarcoFalke commented Apr 15, 2016

Concept ACK. Confirmed changes to verify.sh are working

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 15, 2016

Member

Fixed @fanquake 's nit, cherry-picked #7882 into this.

Member

laanwj commented Apr 15, 2016

Fixed @fanquake 's nit, cherry-picked #7882 into this.

@MarcoFalke

View changes

Show outdated Hide outdated doc/release-process.md
git add ${VERSION}-linux/${SIGNER}
git add ${VERSION}-win-unsigned/${SIGNER}
git add ${VERSION}-osx-unsigned/${SIGNER}
git commit -a

This comment has been minimized.

@PRabahy

PRabahy Apr 15, 2016

Contributor

I always end up doing something like
git commit -a -S -m "${SIGNER}'s unsigned gitian build for ${VERSION}"

The extra -S is probably unnecessary because we end signing a commit containing signed files, but I don't think it should hurt anything and GPG already has to be set up correctly for gsign to work.

@PRabahy

PRabahy Apr 15, 2016

Contributor

I always end up doing something like
git commit -a -S -m "${SIGNER}'s unsigned gitian build for ${VERSION}"

The extra -S is probably unnecessary because we end signing a commit containing signed files, but I don't think it should hurt anything and GPG already has to be set up correctly for gsign to work.

This comment has been minimized.

@MarcoFalke

MarcoFalke Apr 15, 2016

Member

You'd need to git config ... for git commit -S to work

@MarcoFalke

MarcoFalke Apr 15, 2016

Member

You'd need to git config ... for git commit -S to work

This comment has been minimized.

@laanwj

laanwj Apr 15, 2016

Member

There's not really a need to sign commits with signatures in them, I think that'll just result in confusion which signatures are used.

@laanwj

laanwj Apr 15, 2016

Member

There's not really a need to sign commits with signatures in them, I think that'll just result in confusion which signatures are used.

@MarcoFalke

View changes

Show outdated Hide outdated doc/release-process.md
@MarcoFalke

View changes

Show outdated Hide outdated doc/release-process.md
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Apr 23, 2016

Member

utACK cdb7804

Member

MarcoFalke commented Apr 23, 2016

utACK cdb7804

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Apr 24, 2016

Member

utACK cdb7804

Member

fanquake commented Apr 24, 2016

utACK cdb7804

laanwj and others added some commits Apr 15, 2016

doc: Update release process
The actual release process quite diverged from what was written here,
also clarify things a bit.
contrib: remove hardcoded version from verify.sh
Closes #7595 as by removing the hardcoded version number from
`verify.sh`.
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 25, 2016

Member

squashed 2873dbd 3707e43 373bfef 6e25333 cdb7804 into c907f4d 182bec4 f154470
.

Member

laanwj commented Apr 25, 2016

squashed 2873dbd 3707e43 373bfef 6e25333 cdb7804 into c907f4d 182bec4 f154470
.

@laanwj laanwj merged commit f154470 into bitcoin:master Apr 25, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

laanwj added a commit that referenced this pull request Apr 25, 2016

Merge #7881: Update release process
f154470 [contrib] Remove reference to sf and add doc to verify.sh (MarcoFalke)
182bec4 contrib: remove hardcoded version from verify.sh (Wladimir J. van der Laan)
c907f4d doc: Update release process (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment