Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid advertising the node's address when it is not listening or IsInitialBlockDownload(). #792

Merged
merged 1 commit into from Feb 3, 2012

Conversation

gmaxwell
Copy link
Contributor

@gmaxwell gmaxwell commented Feb 1, 2012

This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.

Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.

Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.

…itialBlockDownload().

This also avoids flushing setAddrKnown until 24 hours has passed,
and avoids contacting the external IP services when not listening.

Advertising non-listening nodes is just addr message spam.
It doesn't help the network, in fact it hurts the network,
and it also hurts user's privacy.

Advertising far out of sync nodes doesn't help the network—
they can't even forward (most) transactions and wastes nodes
outbound slots.
@gmaxwell
Copy link
Contributor Author

gmaxwell commented Feb 1, 2012

This is a fairly minimal change for sane behavior. I think we also should check that our listening is working before advertising and that we shouldn't advertise when we're completely full, but the first requires a fair amount of additional code and the second requires careful consideration.

@jgarzik
Copy link
Contributor

jgarzik commented Feb 2, 2012

ACK

1 similar comment
@TheBlueMatt
Copy link
Contributor

ACK

@gavinandresen
Copy link
Contributor

ACK, sanity tested with/without -nolisten.

@gavinandresen gavinandresen merged commit 5d1b8f1 into bitcoin:master Feb 3, 2012
ptschip pushed a commit to ptschip/bitcoin that referenced this pull request Oct 13, 2017
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Feb 22, 2019
4008865 [Travis] Fix trailing whitespaces (warrows)
87b9809 [UI] Rework proposal frames (warrows)
8b8a712 [UI] Add global budget information to governance tab (warrows)
f7674fb [UI] Clean proposal list when updating (warrows)
bbf3274 [UI] Use only one column for Proposal list (warrows)
d6c68c6 [UI] remove unused textlabel from governance page (warrows)
39eb903 [Qt] Add basic GUI voting tab to the wallet (Fuzzbawls)

Tree-SHA512: 438afbb8ed1dbe0892164b6f6b3d0ac3b825b2e7855115f1137bf5bcf454533e375774cd835c19ea529bb1ff0a4f886a3e71e809e9893a102ae841a1a4be8f9a
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants