New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBase58Data::SetString: cleanse the full vector #7922

Merged
merged 1 commit into from Apr 22, 2016

Conversation

Projects
None yet
5 participants
@kazcw
Contributor

kazcw commented Apr 22, 2016

SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 22, 2016

Contributor

ACK 5770449

Contributor

paveljanik commented Apr 22, 2016

ACK 5770449

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 22, 2016

Member

This one is sneaky, good catch.
utACK 5770449

Member

laanwj commented Apr 22, 2016

This one is sneaky, good catch.
utACK 5770449

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Apr 22, 2016

Member

Wow. Good catch!
utACK 5770449

Member

jonasschnelli commented Apr 22, 2016

Wow. Good catch!
utACK 5770449

@laanwj laanwj merged commit 5770449 into bitcoin:master Apr 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 22, 2016

Merge #7922: CBase58Data::SetString: cleanse the full vector
5770449 CBase58Data::SetString: cleanse the full vector (Kaz Wesley)

@kazcw kazcw deleted the kazcw:cleanse-fully branch Apr 29, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jun 4, 2016

CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449
@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 9, 2016

Member

Backported as part of #7938. Removing label 'Needs backport'.

Member

MarcoFalke commented Jun 9, 2016

Backported as part of #7938. Removing label 'Needs backport'.

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449

thokon00 added a commit to faircoin/faircoin that referenced this pull request Jun 28, 2016

CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

CBase58Data::SetString: cleanse the full vector
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449

@dgenr8 dgenr8 referenced this pull request Jan 8, 2017

Merged

Cherries #184

@str4d str4d referenced this pull request Apr 23, 2018

Merged

Bech32 encoding support #3202

zkbot added a commit to zcash/zcash that referenced this pull request Apr 23, 2018

Auto merge of #3202 - str4d:3058-sapling-bech32, r=<try>
Bech32 encoding support and t-addr encoding refactor

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7922
- bitcoin/bitcoin#7825
- bitcoin/bitcoin#8317
- bitcoin/bitcoin#9804
  - Only the commit that changed `base58.cpp`
- bitcoin/bitcoin#11117
- bitcoin/bitcoin#11259
- bitcoin/bitcoin#11167
  - Only the first three commits (the fourth commit depends on #2390, later ones are SegWit-specific).

Part of #3058.

zkbot added a commit to zcash/zcash that referenced this pull request Apr 24, 2018

Auto merge of #3202 - str4d:3058-sapling-bech32, r=<try>
Bech32 encoding support and t-addr encoding refactor

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7922
- bitcoin/bitcoin#7825
- bitcoin/bitcoin#8317
- bitcoin/bitcoin#9804
  - Only the commit that changed `base58.cpp`
- bitcoin/bitcoin#11117
- bitcoin/bitcoin#11259
- bitcoin/bitcoin#11167
  - Only the first three commits (the fourth commit depends on #2390, later ones are SegWit-specific).
- bitcoin/bitcoin#8578
- bitcoin/bitcoin#11372
  - Only the first commit (the rest block on refactoring to remove `CZCEncoding`)

Part of #3058.

zkbot added a commit to zcash/zcash that referenced this pull request Apr 25, 2018

Auto merge of #3202 - str4d:3058-sapling-bech32, r=<try>
Bech32 encoding support and t-addr encoding refactor

Includes code cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7922
- bitcoin/bitcoin#7825
- bitcoin/bitcoin#8317
- bitcoin/bitcoin#9804
  - Only the commit that changed `base58.cpp`
- bitcoin/bitcoin#11117
- bitcoin/bitcoin#11259
- bitcoin/bitcoin#11167
  - Only the first three commits (the fourth commit depends on #2390, later ones are SegWit-specific).
- bitcoin/bitcoin#8578
- bitcoin/bitcoin#11372
  - Only the first three commits (the fourth commit depends on #2390)

Part of #3058.

zkbot added a commit to zcash/zcash that referenced this pull request Apr 25, 2018

Auto merge of #3202 - str4d:3058-sapling-bech32, r=<try>
Bech32 encoding support and address encoding refactor

Includes code cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7922
- bitcoin/bitcoin#7825
- bitcoin/bitcoin#8317
- bitcoin/bitcoin#9804
  - Only the commit that changed `base58.cpp`
- bitcoin/bitcoin#11117
- bitcoin/bitcoin#11259
- bitcoin/bitcoin#11167
  - Only the first three commits (the fourth commit depends on #2390, later ones are SegWit-specific).
- bitcoin/bitcoin#8578
- bitcoin/bitcoin#11372
  - Only the first three commits (the fourth commit depends on #2390)

Part of #3058.

@str4d str4d referenced this pull request Apr 26, 2018

Merged

Upstream encoding cleanups #3213

zkbot added a commit to zcash/zcash that referenced this pull request May 1, 2018

Auto merge of #3213 - str4d:3202-precursor, r=<try>
Upstream encoding cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7922
- bitcoin/bitcoin#7825
- bitcoin/bitcoin#8317
- bitcoin/bitcoin#9804
  - Only the commit that changed `base58.cpp`

Precursor to #3202.

zkbot added a commit to zcash/zcash that referenced this pull request May 1, 2018

Auto merge of #3213 - str4d:3202-precursor, r=<try>
Upstream encoding cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7922
- bitcoin/bitcoin#7825
- bitcoin/bitcoin#8317
- bitcoin/bitcoin#9804
  - Only the commit that changed `base58.cpp`

Precursor to #3202.

zkbot added a commit to zcash/zcash that referenced this pull request May 1, 2018

Auto merge of #3213 - str4d:3202-precursor, r=str4d
Upstream encoding cleanups

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7922
- bitcoin/bitcoin#7825
- bitcoin/bitcoin#8317
- bitcoin/bitcoin#9804
  - Only the commit that changed `base58.cpp`

Precursor to #3202.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment