/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

CBase58Data::SetString: cleanse the full vector #7922

Merged
merged 1 commit into from Apr 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Utils and libraries
Projects
None yet
Milestone
No milestone
5 participants
@kazcw @paveljanik @laanwj @jonasschnelli @MarcoFalke
@kazcw
Contributor

kazcw commented Apr 22, 2016

SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.
@kazcw
CBase58Data::SetString: cleanse the full vector 
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.
5770449
@paveljanik
Contributor

paveljanik commented Apr 22, 2016

ACK 5770449
@laanwj
Owner

laanwj commented Apr 22, 2016

This one is sneaky, good catch.
utACK 5770449

@laanwj laanwj added the Utils and libraries label Apr 22, 2016

@jonasschnelli
Member

jonasschnelli commented Apr 22, 2016

Wow. Good catch!
utACK 5770449

@laanwj laanwj added the Needs backport label Apr 22, 2016

@laanwj laanwj merged commit 5770449 into bitcoin:master Apr 22, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 22, 2016

@laanwj
Merge #7922: CBase58Data::SetString: cleanse the full vector 
5770449 CBase58Data::SetString: cleanse the full vector (Kaz Wesley)
This commit was signed with a verified signature.
@laanwj laanwj Wladimir J. van der Laan
GPG key ID: 74810B012346C9A6 Learn about signing commits
90653bc

@kazcw kazcw deleted the kazcw:cleanse-fully branch Apr 29, 2016

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jun 4, 2016

@kazcw @MarcoFalke
CBase58Data::SetString: cleanse the full vector 
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449
c3d1bc3
@MarcoFalke
Member

MarcoFalke commented Jun 9, 2016

Backported as part of #7938. Removing label 'Needs backport'.

@MarcoFalke MarcoFalke removed the Needs backport label Jun 9, 2016

zander added a commit to zander/bitcoinclassic that referenced this pull request Jun 16, 2016

@kazcw @zander
CBase58Data::SetString: cleanse the full vector 
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449
746a9b7

thokon00 added a commit to faircoin/faircoin that referenced this pull request Jun 28, 2016

@kazcw @thokon00
CBase58Data::SetString: cleanse the full vector 
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449
a6cab88

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

@kazcw @nomnombtc
CBase58Data::SetString: cleanse the full vector 
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449
b3691fa

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

@kazcw @nomnombtc
CBase58Data::SetString: cleanse the full vector 
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449
7dccf15

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

@kazcw @nomnombtc
CBase58Data::SetString: cleanse the full vector 
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449
977a121

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request Nov 14, 2016

@kazcw @sickpig
CBase58Data::SetString: cleanse the full vector 
SetString seems to be passing the length of the wrong variable to
memory_cleanse, resulting in the last byte of the temporary buffer not being
securely erased.

Github-Pull: #7922
Rebased-From: 5770449
This commit was signed with a verified signature.
@sickpig sickpig Andrea Suisani
GPG key ID: A9CA1D0EE3789741 Learn about signing commits
2eeec1a

@dgenr8 dgenr8 referenced this pull request in bitcoinxt/bitcoinxt Jan 8, 2017

Merged

Cherries #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment