New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] push back getaddednodeinfo dead value #7926

Merged
merged 1 commit into from Apr 28, 2016

Conversation

Projects
None yet
6 participants
@instagibbs
Member

instagibbs commented Apr 22, 2016

I believe this is the desired behavior, if this is unneeded we should just delete the else branch.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Apr 22, 2016

Contributor

Looks like this was the original goal, yes.

utACK 9c0bcb6

Contributor

paveljanik commented Apr 22, 2016

Looks like this was the original goal, yes.

utACK 9c0bcb6

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Apr 23, 2016

Member

utACK 9c0bcb6

Member

sipa commented Apr 23, 2016

utACK 9c0bcb6

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Apr 25, 2016

Member

Yes, I've never used this RPC but this makes sense I think. I think the point is to add entries that failed lookup to the list but as non-connected.
utACK 9c0bcb6

Member

laanwj commented Apr 25, 2016

Yes, I've never used this RPC but this makes sense I think. I think the point is to add entries that failed lookup to the list but as non-connected.
utACK 9c0bcb6

@TheBlueMatt

This comment has been minimized.

Show comment
Hide comment
@TheBlueMatt

TheBlueMatt Apr 25, 2016

Contributor

utACK 9c0bcb6

Contributor

TheBlueMatt commented Apr 25, 2016

utACK 9c0bcb6

@laanwj laanwj merged commit 9c0bcb6 into bitcoin:master Apr 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Apr 28, 2016

Merge #7926: [RPC] push back getaddednodeinfo dead value
9c0bcb6 push back getaddednodeinfo dead value (instagibbs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment