New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] add feerate option to fundrawtransaction #7967

Merged
merged 2 commits into from Jun 3, 2016

Conversation

Projects
None yet
4 participants
@jonasschnelli
Member

jonasschnelli commented Apr 28, 2016

Fixes #7963

Currently fundrawtransaction always uses the default confirm target to estimate the fee (with a fallback to payTxFee).

This PR adds an optional feeRate parameter to fundrawtransaction that overrides the estimated minimum fee.

Show outdated Hide outdated src/wallet/wallet.cpp
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli May 6, 2016

Member

Added a commit that add an explicit boolean for overriding the estimated fee rate (overrideFeeRate). This would allow to use 0 as fee rate (zero fee transaction) but would require 0 as minRelayTxFee.

Member

jonasschnelli commented May 6, 2016

Added a commit that add an explicit boolean for overriding the estimated fee rate (overrideFeeRate). This would allow to use 0 as fee rate (zero fee transaction) but would require 0 as minRelayTxFee.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 17, 2016

Member

utACK 04eaa90

Member

sipa commented May 17, 2016

utACK 04eaa90

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 3, 2016

Member

utACK 04eaa90

Member

laanwj commented Jun 3, 2016

utACK 04eaa90

@laanwj laanwj merged commit 04eaa90 into bitcoin:master Jun 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 3, 2016

Merge #7967: [RPC] add feerate option to fundrawtransaction
04eaa90 Add more clear interface for CoinControl.h regarding individual feerate (Jonas Schnelli)
3b35e48 [RPC] add feerate option to fundrawtransaction (Jonas Schnelli)
inputs = []
outputs = {self.nodes[2].getnewaddress() : 1}
rawtx = self.nodes[3].createrawtransaction(inputs, outputs)
result = self.nodes[3].fundrawtransaction(rawtx, )

This comment has been minimized.

@MarcoFalke

MarcoFalke Jun 3, 2016

Member

Nit: empty arg.
Nit: Missing comment mentioning that min_relay_tx_fee=1000 is used.

(Comments help to identify the issue when something breaks)

@MarcoFalke

MarcoFalke Jun 3, 2016

Member

Nit: empty arg.
Nit: Missing comment mentioning that min_relay_tx_fee=1000 is used.

(Comments help to identify the issue when something breaks)

@@ -2458,6 +2458,7 @@ UniValue fundrawtransaction(const UniValue& params, bool fHelp)
" \"changePosition\" (numeric, optional, default random) The index of the change output\n"
" \"includeWatching\" (boolean, optional, default false) Also select inputs which are watch only\n"
" \"lockUnspents\" (boolean, optional, default false) Lock selected unspent outputs\n"
" \"feeRate\" (numeric, optional, default 0=estimate) Set a specific feerate (fee per KB)\n"

This comment has been minimized.

@MarcoFalke

MarcoFalke Jun 3, 2016

Member

the default is not "estimate" but whatever happens to be set by the user on startup or after startup.

Either make it default 0 or default not set.

@MarcoFalke

MarcoFalke Jun 3, 2016

Member

the default is not "estimate" but whatever happens to be set by the user on startup or after startup.

Either make it default 0 or default not set.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 3, 2016

Member

Post merge utACK 04eaa90

Member

MarcoFalke commented Jun 3, 2016

Post merge utACK 04eaa90

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7967: [RPC] add feerate option to fundrawtransaction
04eaa90 Add more clear interface for CoinControl.h regarding individual feerate (Jonas Schnelli)
3b35e48 [RPC] add feerate option to fundrawtransaction (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7967: [RPC] add feerate option to fundrawtransaction
04eaa90 Add more clear interface for CoinControl.h regarding individual feerate (Jonas Schnelli)
3b35e48 [RPC] add feerate option to fundrawtransaction (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017

Merge #7967: [RPC] add feerate option to fundrawtransaction
04eaa90 Add more clear interface for CoinControl.h regarding individual feerate (Jonas Schnelli)
3b35e48 [RPC] add feerate option to fundrawtransaction (Jonas Schnelli)

@dagurval dagurval referenced this pull request Dec 27, 2017

Merged

Add fundrawtransaction #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment