New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comments on the design of AttemptToEvictConnection. #7974

Merged
merged 1 commit into from May 4, 2016

Conversation

Projects
None yet
4 participants
@gmaxwell
Member

gmaxwell commented Apr 29, 2016

Some developers clearly don't get this and have been posting
"improvements" that create clear vulnerabilities. It should
have been better explained in the code, since the design
is somewhat subtle and getting it right is important.

@MarcoFalke MarcoFalke added the Docs label Apr 29, 2016

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Apr 29, 2016

Member

@pstratem It's your code I'm commenting here.

Member

gmaxwell commented Apr 29, 2016

@pstratem It's your code I'm commenting here.

More comments on the design of AttemptToEvictConnection.
Some developers clearly don't get this and have been posting
 "improvements" that create clear vulnerabilities.  It should
 have been better explained in the code, since the design
 is somewhat subtle and getting it right is important.
@pstratem

This comment has been minimized.

Show comment
Hide comment
@pstratem

pstratem Apr 30, 2016

Contributor

ACK d90351f

Contributor

pstratem commented Apr 30, 2016

ACK d90351f

@laanwj laanwj merged commit d90351f into bitcoin:master May 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 4, 2016

Merge #7974: More comments on the design of AttemptToEvictConnection.
d90351f More comments on the design of AttemptToEvictConnection. (Gregory Maxwell)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7974: More comments on the design of AttemptToEvictConnection.
d90351f More comments on the design of AttemptToEvictConnection. (Gregory Maxwell)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7974: More comments on the design of AttemptToEvictConnection.
d90351f More comments on the design of AttemptToEvictConnection. (Gregory Maxwell)

codablock added a commit to codablock/dash that referenced this pull request Dec 20, 2017

Merge #7974: More comments on the design of AttemptToEvictConnection.
d90351f More comments on the design of AttemptToEvictConnection. (Gregory Maxwell)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment