Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[qa] smartfees: Properly use ordered dict #7980
+1 for using OrderedDict. Normal dicts's order is randomized (they use a random seed for security reasons) and it's clear that the order of those outputs here matters.
Aside: as of Python 3.5 OrderedDict is implemented in C and hence almost as fast as normal dict. Not that it matters in this particular instance.
Still not able to reproduce here on master, OS X.
On the other hand, this command now failed for me on OS X, with this PR:
Edit: Python is Python 2.7 on this test machine.
When I run the test as
Using your method (with or without