New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: No need to check for leveldb atomics #7982

Merged
merged 1 commit into from May 4, 2016

Conversation

Projects
None yet
4 participants
@theuni
Member

theuni commented Apr 30, 2016

They're guaranteed with c++11

build: No need to check for leveldb atomics
They're guaranteed with c++11
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 1, 2016

Contributor

utACK de98290

Contributor

paveljanik commented May 1, 2016

utACK de98290

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 2, 2016

Member

utACK de98290

This reminds me, we should make tinyformat use variadic template as well (TINYFORMAT_USE_VARIADIC_TEMPLATES) if that's not the case yet automatically.

Member

laanwj commented May 2, 2016

utACK de98290

This reminds me, we should make tinyformat use variadic template as well (TINYFORMAT_USE_VARIADIC_TEMPLATES) if that's not the case yet automatically.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 2, 2016

Member

A quick test shows that it auto-detects and uses them automatically, at least on clang 3.9:

#ifdef TINYFORMAT_USE_VARIADIC_TEMPLATES
#error Using variadic templates
#endif

The detection method is a tad outdated though:

#   ifdef __GXX_EXPERIMENTAL_CXX0X__
#       define TINYFORMAT_USE_VARIADIC_TEMPLATES
#   endif
Member

laanwj commented May 2, 2016

A quick test shows that it auto-detects and uses them automatically, at least on clang 3.9:

#ifdef TINYFORMAT_USE_VARIADIC_TEMPLATES
#error Using variadic templates
#endif

The detection method is a tad outdated though:

#   ifdef __GXX_EXPERIMENTAL_CXX0X__
#       define TINYFORMAT_USE_VARIADIC_TEMPLATES
#   endif
@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni May 2, 2016

Member

@laanwj Agreed, defining it explicitly couldn't hurt.

Member

theuni commented May 2, 2016

@laanwj Agreed, defining it explicitly couldn't hurt.

@laanwj laanwj merged commit de98290 into bitcoin:master May 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 4, 2016

Merge #7982: build: No need to check for leveldb atomics
de98290 build: No need to check for leveldb atomics (Cory Fields)

laanwj added a commit to laanwj/bitcoin that referenced this pull request May 4, 2016

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin#7982 (comment))
and is unnecessary for us anyhow.

deadalnix added a commit to deadalnix/bitcoin that referenced this pull request Jan 11, 2017

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin#7982 (comment))
and is unnecessary for us anyhow.

deadalnix added a commit to deadalnix/bitcoin that referenced this pull request Jan 11, 2017

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin#7982 (comment))
and is unnecessary for us anyhow.

deadalnix added a commit to deadalnix/bitcoin that referenced this pull request Jan 15, 2017

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin#7982 (comment))
and is unnecessary for us anyhow.

deadalnix added a commit to deadalnix/bitcoin that referenced this pull request Jan 16, 2017

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin#7982 (comment))
and is unnecessary for us anyhow.

deadalnix added a commit to deadalnix/bitcoin that referenced this pull request Jan 17, 2017

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin#7982 (comment))
and is unnecessary for us anyhow.

deadalnix added a commit to deadalnix/bitcoin that referenced this pull request Jan 19, 2017

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin#7982 (comment))
and is unnecessary for us anyhow.

deadalnix added a commit to deadalnix/bitcoin that referenced this pull request Jan 19, 2017

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin#7982 (comment))
and is unnecessary for us anyhow.

dagurval added a commit to dagurval/bitcoinxt that referenced this pull request Apr 23, 2017

tinyformat: force USE_VARIADIC_TEMPLATES
Now that we started using c++11, force use of variadic templates.

The autodetection may be wonky on some compilers, see discussion
[here](bitcoin/bitcoin#7982 (comment))
and is unnecessary for us anyhow.

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7982: build: No need to check for leveldb atomics
de98290 build: No need to check for leveldb atomics (Cory Fields)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7982: build: No need to check for leveldb atomics
de98290 build: No need to check for leveldb atomics (Cory Fields)

codablock added a commit to codablock/dash that referenced this pull request Dec 20, 2017

Merge #7982: build: No need to check for leveldb atomics
de98290 build: No need to check for leveldb atomics (Cory Fields)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment