New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend #7956 with one more test. #7992

Merged
merged 3 commits into from Jun 2, 2016

Conversation

Projects
None yet
4 participants
@TheBlueMatt
Contributor

TheBlueMatt commented May 3, 2016

No description provided.

laanwj added some commits Apr 26, 2016

test: Add more thorough test for dbwrapper iterators
I made a silly mistake in a database wrapper where keys
were sorted by char instead of uint8_t. As x86 char is signed
the sorting for the block index database was messed up, resulting
in a segfault due to missing records.

Add a test to catch:
- Wrong sorting
- Seeking errors
- Iteration result not complete

@laanwj laanwj added the Tests label May 3, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 3, 2016

Member

Thanks!
(continues #7956)

Member

laanwj commented May 3, 2016

Thanks!
(continues #7956)

@paveljanik

View changes

Show outdated Hide outdated src/test/dbwrapper_tests.cpp
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 3, 2016

Contributor

Concept ACK

Contributor

paveljanik commented May 3, 2016

Concept ACK

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 17, 2016

Member

@TheBlueMatt Can you address 7be4754#r61928804 ?

Member

sipa commented May 17, 2016

@TheBlueMatt Can you address 7be4754#r61928804 ?

@sipa sipa referenced this pull request May 26, 2016

Merged

Addrman offline attempts #8065

@sipa sipa merged commit 269a440 into bitcoin:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request Jun 2, 2016

Merge #7992: Extend #7956 with one more test.
269a440 Add test for dbwrapper iterators with same-prefix keys. (Matt Corallo)
6030625 test: Add more thorough test for dbwrapper iterators (Wladimir J. van der Laan)
84c13e7 chain: Add assertion in case of missing records in index db (Wladimir J. van der Laan)

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jun 9, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 12, 2016

nomnombtc added a commit to nomnombtc/bitcoin that referenced this pull request Nov 13, 2016

@str4d str4d referenced this pull request Apr 4, 2018

Merged

Additional dbwrapper tests #3146

zkbot added a commit to zcash/zcash that referenced this pull request Apr 4, 2018

Auto merge of #3146 - str4d:bc-7956-dbwrapper-tests, r=str4d
Additional dbwrapper tests

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7992
- bitcoin/bitcoin#9867
  - Only the commit affecting dbwrapper tests
- bitcoin/bitcoin#9610
  - Only the change affecting dbwrapper tests
- bitcoin/bitcoin#10844

zkbot added a commit to zcash/zcash that referenced this pull request Apr 4, 2018

Auto merge of #3146 - str4d:bc-7956-dbwrapper-tests, r=str4d
Additional dbwrapper tests

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7992
- bitcoin/bitcoin#9867
  - Only the commit affecting dbwrapper tests
- bitcoin/bitcoin#9610
  - Only the change affecting dbwrapper tests
- bitcoin/bitcoin#10844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment