New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat #7993

Merged
merged 6 commits into from Jun 8, 2016

Conversation

Projects
None yet
5 participants
@fanquake
Member

fanquake commented May 3, 2016

miniupnpc 2.0 changelog
expat 2.1.1 changelog
freetype 2.6.3, changelog, change download url to the mirror at gnu.org
ccache 3.2.5 changelog
zeromq 4.1.4 changelog
Latest config.guess & config.sub

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni May 3, 2016

Member

adding "--without-libsodium" should fix the zmq build, by the looks

Member

theuni commented May 3, 2016

adding "--without-libsodium" should fix the zmq build, by the looks

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 10, 2016

Member

Rebased onto master, and should have fixed the ZeroMQ build issues (needed --without-libsodium and no longer need to look in the src dir)

Member

fanquake commented May 10, 2016

Rebased onto master, and should have fixed the ZeroMQ build issues (needed --without-libsodium and no longer need to look in the src dir)

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 12, 2016

Member

Added two additional commits updating miniupnpc and expat
Expat changelog is here, the major change is CVE-2015-1283 — Multiple integer overflows in the XML_GetBuffer function

miniupnpc changelog

Member

fanquake commented May 12, 2016

Added two additional commits updating miniupnpc and expat
Expat changelog is here, the major change is CVE-2015-1283 — Multiple integer overflows in the XML_GetBuffer function

miniupnpc changelog

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 20, 2016

Member

utACK

Expat changelog is here, the major change is CVE-2015-1283 — Multiple integer overflows in the XML_GetBuffer function

Oh! I see expat is used indirectly through dbus. Already wondered what we were using a XML parsing library for.
Wonder if any of that code ends up in the executable or it's just used for dbus' build tools.

Member

laanwj commented May 20, 2016

utACK

Expat changelog is here, the major change is CVE-2015-1283 — Multiple integer overflows in the XML_GetBuffer function

Oh! I see expat is used indirectly through dbus. Already wondered what we were using a XML parsing library for.
Wonder if any of that code ends up in the executable or it's just used for dbus' build tools.

@fanquake fanquake changed the title from [depends] Update FreeType, ccache, ZeroMQ to [depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat May 21, 2016

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 1, 2016

Member

Concept ACK. I haven't checked the hashes.

Member

sipa commented Jun 1, 2016

Concept ACK. I haven't checked the hashes.

@@ -15,11 +15,11 @@ define $(package)_config_cmds
endef
define $(package)_build_cmds
$(MAKE) -C src

This comment has been minimized.

@theuni

theuni Jun 1, 2016

Member

Please use:
$(MAKE) libzmq.la to avoid building stuff other than the lib

@theuni

theuni Jun 1, 2016

Member

Please use:
$(MAKE) libzmq.la to avoid building stuff other than the lib

@theuni

View changes

Show outdated Hide outdated depends/packages/zeromq.mk
@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jun 1, 2016

Member

@laanwj Yes, through dbus and fontconfig. Though now that I look at it, we could probably just skip building dbus since qt dlopens it.

Still need it for fontconfig though :(

Member

theuni commented Jun 1, 2016

@laanwj Yes, through dbus and fontconfig. Though now that I look at it, we could probably just skip building dbus since qt dlopens it.

Still need it for fontconfig though :(

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jun 1, 2016

Member

utACK, with the exception of the two nits.

Member

theuni commented Jun 1, 2016

utACK, with the exception of the two nits.

fanquake added some commits May 3, 2016

[depends] Freetype 2.6.3
Update FreeType, and change the download location to gnu.org. This is
the other official download location listed on freetype.org

@fanquake fanquake referenced this pull request Jun 2, 2016

Closed

[WIP] [depends] Qt 5.6.1 #8053

0 of 1 task complete
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jun 2, 2016

Member

Nits addressed, and rebased on master

@theuni added a note about removing dbus to #8053. Is there any value in bumping it here?

Member

fanquake commented Jun 2, 2016

Nits addressed, and rebased on master

@theuni added a note about removing dbus to #8053. Is there any value in bumping it here?

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 8, 2016

Member

@theuni added a note about removing dbus to #8053. Is there any value in bumping it here?

No urgency in bumping. But removal that should be discussed separately. We do use dbus for the notification stuff in the Qt GUI, so there are (minor) consequences for users.

Member

laanwj commented Jun 8, 2016

@theuni added a note about removing dbus to #8053. Is there any value in bumping it here?

No urgency in bumping. But removal that should be discussed separately. We do use dbus for the notification stuff in the Qt GUI, so there are (minor) consequences for users.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 8, 2016

Member

Though now that I look at it, we could probably just skip building dbus since qt dlopens it.

Oh I missed that part. Yes makes sense to remove it then.

Member

laanwj commented Jun 8, 2016

Though now that I look at it, we could probably just skip building dbus since qt dlopens it.

Oh I missed that part. Yes makes sense to remove it then.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 8, 2016

Member

utACK 6a4cf16

Member

laanwj commented Jun 8, 2016

utACK 6a4cf16

@laanwj laanwj merged commit 6a4cf16 into bitcoin:master Jun 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 8, 2016

Merge #7993: [depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat
6a4cf16 [depends] expat 2.1.1 (fanquake)
3e0587b [depends] miniupnpc 2.0 (fanquake)
87b8175 [depends] Latest config.guess & config.sub (fanquake)
bd3cbd5 [depends] ZeroMQ 4.1.4 (fanquake)
0385202 [depends] ccache 3.2.5 (fanquake)
2b2d52e [depends] Freetype 2.6.3 (fanquake)

@fanquake fanquake referenced this pull request Jun 17, 2016

Merged

[Qt] Bump to Qt5.6.1 #8210

@fanquake fanquake deleted the fanquake:depends-no-sourceforge branch Jun 22, 2016

@str4d str4d referenced this pull request Jan 31, 2017

Merged

Add ZeroMQ notifications #2050

zkbot added a commit to zcash/zcash that referenced this pull request Feb 9, 2017

zkbot added a commit to zcash/zcash that referenced this pull request Feb 9, 2017

zkbot added a commit to zcash/zcash that referenced this pull request Feb 9, 2017

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #7993: [depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat
6a4cf16 [depends] expat 2.1.1 (fanquake)
3e0587b [depends] miniupnpc 2.0 (fanquake)
87b8175 [depends] Latest config.guess & config.sub (fanquake)
bd3cbd5 [depends] ZeroMQ 4.1.4 (fanquake)
0385202 [depends] ccache 3.2.5 (fanquake)
2b2d52e [depends] Freetype 2.6.3 (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #7993: [depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat
6a4cf16 [depends] expat 2.1.1 (fanquake)
3e0587b [depends] miniupnpc 2.0 (fanquake)
87b8175 [depends] Latest config.guess & config.sub (fanquake)
bd3cbd5 [depends] ZeroMQ 4.1.4 (fanquake)
0385202 [depends] ccache 3.2.5 (fanquake)
2b2d52e [depends] Freetype 2.6.3 (fanquake)

@schinzelh schinzelh referenced this pull request Oct 19, 2017

Closed

[WIP] Update build system to Bitcoin 0.13.2 #1692

22 of 24 tasks complete

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017

Merge #7993: [depends] Bump Freetype, ccache, ZeroMQ, miniupnpc, expat
6a4cf16 [depends] expat 2.1.1 (fanquake)
3e0587b [depends] miniupnpc 2.0 (fanquake)
87b8175 [depends] Latest config.guess & config.sub (fanquake)
bd3cbd5 [depends] ZeroMQ 4.1.4 (fanquake)
0385202 [depends] ccache 3.2.5 (fanquake)
2b2d52e [depends] Freetype 2.6.3 (fanquake)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment