New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add op csv tests to script_tests.json #7994

Merged
merged 1 commit into from May 16, 2016

Conversation

Projects
None yet
7 participants
@Christewart
Contributor

Christewart commented May 3, 2016

Adds OP_CHECKSEQUENCEVERIFY tests to script_tests.json

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak May 3, 2016

Member

You can add extra tests, as was commented on #7540, renaming isn't appropriate until the softfork activated, since it's still a NOP at the moment.

Member

btcdrak commented May 3, 2016

You can add extra tests, as was commented on #7540, renaming isn't appropriate until the softfork activated, since it's still a NOP at the moment.

Show outdated Hide outdated src/script/script.cpp
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 10, 2016

Member

ACK after squash

Member

laanwj commented May 10, 2016

ACK after squash

@laanwj laanwj added the Tests label May 10, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
Member

MarcoFalke commented May 10, 2016

Adding basic tests for OP_CSV inside of script_tests.json
Changing NOP3 op name to OP_CHECKSEQUENCEVERIFY, renaming instances of OP_NOP3 in script_tests.json to CHECKSEQUENCEVERIFY

Cleaning up NOP3 comment

Re-adding test cases that were accidentally deleted, removing dupicated test case, fixing formatting

Removing re-labeling of OP_NOP3 to OP_CSV

Fixing whitespace issues

@sipa sipa merged commit 10e83d7 into bitcoin:master May 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request May 16, 2016

Merge #7994: Add op csv tests to script_tests.json
10e83d7 Adding basic tests for OP_CSV inside of script_tests.json (Chris Stewart)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment