New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal handling: fReopenDebugLog and fRequestShutdown should be type sig_atomic_t #8004

Merged
merged 1 commit into from May 12, 2016

Conversation

Projects
None yet
7 participants
@catilac
Contributor

catilac commented May 5, 2016

This allows access as an atomic variable in the presence of async interrupts.

See issue #7433 for more details
fixes: #7433

@laanwj laanwj added the Bug label May 5, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 5, 2016

Member

I think you're missing signal.h include at the places you use the type.

Member

laanwj commented May 5, 2016

I think you're missing signal.h include at the places you use the type.

@catilac

This comment has been minimized.

Show comment
Hide comment
@catilac

catilac May 8, 2016

Contributor

@laanwj ahh you were right 👍

Contributor

catilac commented May 8, 2016

@laanwj ahh you were right 👍

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 9, 2016

Member

@catilac Mind to squash the commits?

Member

MarcoFalke commented May 9, 2016

@catilac Mind to squash the commits?

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 9, 2016

Member

ACK after squash into one "atomic" commit
E.g.

$ git checkout fix_signal_handler
$ git rebase -i 88b77c7
# set bottom two commits from 'pick' to 'squash', save and quit editor
$ git push -f
Member

laanwj commented May 9, 2016

ACK after squash into one "atomic" commit
E.g.

$ git checkout fix_signal_handler
$ git rebase -i 88b77c7
# set bottom two commits from 'pick' to 'squash', save and quit editor
$ git push -f
fReopenDebugLog and fRequestShutdown should be type sig_atomic_t
This allows access as an atomic variable in the presence
of async interrupts.

See issue #7433 for more details
fixes: #7433
@catilac

This comment has been minimized.

Show comment
Hide comment
@catilac

catilac May 9, 2016

Contributor

Ah right! Done and done.

Contributor

catilac commented May 9, 2016

Ah right! Done and done.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 9, 2016

Member

utACK 3262316

Member

sipa commented May 9, 2016

utACK 3262316

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake
Member

fanquake commented May 10, 2016

utACK 3262316

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens May 11, 2016

Contributor

utACK 3262316

Contributor

dcousens commented May 11, 2016

utACK 3262316

@laanwj laanwj merged commit 3262316 into bitcoin:master May 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 12, 2016

Merge #8004: signal handling: fReopenDebugLog and fRequestShutdown sh…
…ould be type sig_atomic_t

3262316 fReopenDebugLog and fRequestShutdown should be type sig_atomic_t (Chirag Davé)
@elfring

This comment has been minimized.

Show comment
Hide comment
@elfring

elfring commented May 12, 2016

zkbot pushed a commit to zcash/zcash that referenced this pull request Oct 25, 2016

zkbot
Auto merge of #1634 - bitcartel:upstream_8123_race_condition_std_atom…
…ic, r=daira

Upstream 8123 race condition

This backports a fix from upstream, with commits applied in sequence:
bitcoin/bitcoin#8004
bitcoin/bitcoin#8112
bitcoin/bitcoin#8123

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8004: signal handling: fReopenDebugLog and fRequestShutdown sh…
…ould be type sig_atomic_t

3262316 fReopenDebugLog and fRequestShutdown should be type sig_atomic_t (Chirag Davé)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8004: signal handling: fReopenDebugLog and fRequestShutdown sh…
…ould be type sig_atomic_t

3262316 fReopenDebugLog and fRequestShutdown should be type sig_atomic_t (Chirag Davé)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8004: signal handling: fReopenDebugLog and fRequestShutdown sh…
…ould be type sig_atomic_t

3262316 fReopenDebugLog and fRequestShutdown should be type sig_atomic_t (Chirag Davé)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment