New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fixed invalid example paths in gitian-building.md #8009

Merged
merged 1 commit into from May 6, 2016

Conversation

Projects
None yet
4 participants
@JeremyRand
Contributor

JeremyRand commented May 5, 2016

The example local paths for "Building fully offline" were missing a forward slash prior to the ".git". This caused an error when trying to run gbuild, like this:

fatal: '/home/user/bitcoin.git' does not appear to be a git repository
fatal: Could not read from remote repository.

This PR fixes that.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 5, 2016

Member

I don't think the /.git is necessary at all.
This is probably a case of the person writing this having the directories named like <something>.git.
Do agree with removing those though, as that prefix is not there by default.

Member

laanwj commented May 5, 2016

I don't think the /.git is necessary at all.
This is probably a case of the person writing this having the directories named like <something>.git.
Do agree with removing those though, as that prefix is not there by default.

@JeremyRand

This comment has been minimized.

Show comment
Hide comment
@JeremyRand

JeremyRand May 5, 2016

Contributor

@laanwj Indeed, you are correct; the /.git is optional. Leaving out the / while having the .git present does not work, though (which is what the current docs say). Would you prefer that I modify this PR to remove the /.git?

Contributor

JeremyRand commented May 5, 2016

@laanwj Indeed, you are correct; the /.git is optional. Leaving out the / while having the .git present does not work, though (which is what the current docs say). Would you prefer that I modify this PR to remove the /.git?

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 5, 2016

Member

Yes, I'd say just leave

BTCPATH=/some/root/path/bitcoin
SIGPATH=/some/root/path/bitcoin-detached-sigs
Member

laanwj commented May 5, 2016

Yes, I'd say just leave

BTCPATH=/some/root/path/bitcoin
SIGPATH=/some/root/path/bitcoin-detached-sigs
Fixed invalid example paths in gitian-building.md
The example local paths for "Building fully offline" have an extraneous ".git".  This caused an error when trying to run gbuild, like this

fatal: '/home/user/bitcoin.git' does not appear to be a git repository
fatal: Could not read from remote repository.

This commit fixes that.
@JeremyRand

This comment has been minimized.

Show comment
Hide comment
@JeremyRand

JeremyRand May 5, 2016

Contributor

@laanwj Done.

Contributor

JeremyRand commented May 5, 2016

@laanwj Done.

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake
Member

fanquake commented May 6, 2016

utACK b06f6a9

@MarcoFalke MarcoFalke added the Docs label May 6, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented May 6, 2016

utACK b06f6a9

@laanwj laanwj merged commit b06f6a9 into bitcoin:master May 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 6, 2016

Merge #8009: Docs: Fixed invalid example paths in gitian-building.md
b06f6a9 Fixed invalid example paths in gitian-building.md (JeremyRand)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge bitcoin#8009: Docs: Fixed invalid example paths in gitian-build…
…ing.md

b06f6a9 Fixed invalid example paths in gitian-building.md (JeremyRand)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#8009: Docs: Fixed invalid example paths in gitian-build…
…ing.md

b06f6a9 Fixed invalid example paths in gitian-building.md (JeremyRand)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge bitcoin#8009: Docs: Fixed invalid example paths in gitian-build…
…ing.md

b06f6a9 Fixed invalid example paths in gitian-building.md (JeremyRand)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment