New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Simplify OS X build notes #8029

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
6 participants
@fanquake
Member

fanquake commented May 9, 2016

Add --c++11 flag to brew dependancies that support it
Remove release-build section, this is covered by depends/release-notes

@theuni can I get your thoughts on adding the --c++11 flag to brew dependancies?

Link to the rendered markdown

@MarcoFalke MarcoFalke added the Docs label May 9, 2016

@paveljanik

View changes

Show outdated Hide outdated doc/build-osx.md
@paveljanik

View changes

Show outdated Hide outdated doc/build-osx.md
@paveljanik

View changes

Show outdated Hide outdated doc/build-osx.md
@paveljanik

View changes

Show outdated Hide outdated doc/build-osx.md
@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni May 10, 2016

Member

Looks like protobuf supports the c++11 flag as well.
edit: whoops, misread. This is already there.

Member

theuni commented May 10, 2016

Looks like protobuf supports the c++11 flag as well.
edit: whoops, misread. This is already there.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni May 10, 2016

Member

I don't see a c++11 flag in the qt build. @fanquake Can you confirm that it gets built that way on 10.11? I'm worried that the detection might fail without a stdlib specified (similar to boost here)

If not, we should upstream a patch while we're at it.

Member

theuni commented May 10, 2016

I don't see a c++11 flag in the qt build. @fanquake Can you confirm that it gets built that way on 10.11? I'm worried that the detection might fail without a stdlib specified (similar to boost here)

If not, we should upstream a patch while we're at it.

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni May 10, 2016

Member

ACK adding the c++11 flags and simplifying.

Also, since it's no longer mentioned (hasn't been in a while, I suppose), we should remove the port check from configure.ac

Member

theuni commented May 10, 2016

ACK adding the c++11 flags and simplifying.

Also, since it's no longer mentioned (hasn't been in a while, I suppose), we should remove the port check from configure.ac

[Doc] Simplify OS X build notes
Add —c++11 flags to brew dependancies that support it
Remove release-build section, this is covered by depends/release-notes
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 12, 2016

Member

Changed step 4 to make deploy

@theuni I'll start submitting PRs to Homebrew to update dependancies (and sub dependancies) that we use.

Member

fanquake commented May 12, 2016

Changed step 4 to make deploy

@theuni I'll start submitting PRs to Homebrew to update dependancies (and sub dependancies) that we use.

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 12, 2016

Member

PRs to update miniupnpc, expat, dbus, ccache

Member

fanquake commented May 12, 2016

PRs to update miniupnpc, expat, dbus, ccache

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 14, 2016

Member

I don't see a c++11 flag in the qt build. @fanquake Can you confirm that it gets built that way on 10.11? I'm worried that the detection might fail without a stdlib specified (similar to boost here)

@theuni Looking at the output of brew install qt5 --verbose --build-from-source, it looks like it is.

   Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3)
   qmake vars: QMAKE_CC = clang QMAKE_CXX = clang++
   Build options:
   Configuration: c++11 c++14 c++1z
   Using C++ standard: c++1z

Assuming their bottles are built the same way.

Member

fanquake commented May 14, 2016

I don't see a c++11 flag in the qt build. @fanquake Can you confirm that it gets built that way on 10.11? I'm worried that the detection might fail without a stdlib specified (similar to boost here)

@theuni Looking at the output of brew install qt5 --verbose --build-from-source, it looks like it is.

   Build type: macx-clang (x86_64, CPU features: cx16 mmx sse sse2 sse3 ssse3)
   qmake vars: QMAKE_CC = clang QMAKE_CXX = clang++
   Build options:
   Configuration: c++11 c++14 c++1z
   Using C++ standard: c++1z

Assuming their bottles are built the same way.

@arowser

This comment has been minimized.

Show comment
Hide comment
@arowser

arowser May 25, 2016

Contributor

Can one of the admins verify this patch?

Contributor

arowser commented May 25, 2016

Can one of the admins verify this patch?

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented Jun 2, 2016

ACK 2692e1b

@jonasschnelli jonasschnelli merged commit 2692e1b into bitcoin:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jun 2, 2016

Merge #8029: [Doc] Simplify OS X build notes
2692e1b [Doc] Simplify OS X build notes (fanquake)

@fanquake fanquake deleted the fanquake:osx-build-notes branch Jun 12, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8029: [Doc] Simplify OS X build notes
2692e1b [Doc] Simplify OS X build notes (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8029: [Doc] Simplify OS X build notes
2692e1b [Doc] Simplify OS X build notes (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017

Merge #8029: [Doc] Simplify OS X build notes
2692e1b [Doc] Simplify OS X build notes (fanquake)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment