New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Revert fatal-ness of missing python-zmq #8030

Merged
merged 1 commit into from May 9, 2016

Conversation

Projects
None yet
3 participants
@laanwj
Member

laanwj commented May 9, 2016

It looks like travis is using the travis.yml from the branch, but runs the test script from the branch merged into master. This causes pull requests created before the QA tests python 3 transition to fail due to missing python3-zmq package.
This happens in, for example, #8006.

This temporarily reverts fa05e22 (#7851). It can be restored when this is no longer an issue.

test: Revert fatal-ness of missing python-zmq
It looks like travis is using the `travis.yml` from the branch, but runs
the test script from the branch merged into master. This causes
pull requests created before the QA tests python 3 transition to fail.

This temporarily reverts fa05e22
(#7851). It can be restored when this is no longer an issue.

@laanwj laanwj added the Tests label May 9, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 9, 2016

Member

65fee8e fine with me, if it helps getting rid of the odd travis failures.

Member

MarcoFalke commented May 9, 2016

65fee8e fine with me, if it helps getting rid of the odd travis failures.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 9, 2016

Contributor

ACK 65fee8e

Contributor

paveljanik commented May 9, 2016

ACK 65fee8e

@laanwj laanwj merged commit 65fee8e into bitcoin:master May 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 9, 2016

Merge #8030: test: Revert fatal-ness of missing python-zmq
65fee8e test: Revert fatal-ness of missing python-zmq (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8030: test: Revert fatal-ness of missing python-zmq
65fee8e test: Revert fatal-ness of missing python-zmq (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8030: test: Revert fatal-ness of missing python-zmq
65fee8e test: Revert fatal-ness of missing python-zmq (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8030: test: Revert fatal-ness of missing python-zmq
65fee8e test: Revert fatal-ness of missing python-zmq (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment