New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Move berkeleydb version reporting to wallet #8036

Merged
merged 1 commit into from May 10, 2016

Conversation

Projects
None yet
5 participants
@laanwj
Member

laanwj commented May 10, 2016

Move the version reporting to Wallet::Verify, before starting verification of the wallet (as this is the earliest point that the wallet is actually going to be accessed).

This removes the dependency of init on a specific wallet database library.

A further, trivial step towards resolving #7965.

@laanwj laanwj added the Wallet label May 10, 2016

init: Move berkeleydb version reporting to wallet
Move the version reporting to Wallet::Verify, before starting
verification of the wallet.

This removes the dependency of init on a specific wallet database
library.

A further, trivial step towards resolving #7965.
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli May 10, 2016

Member

Yes. This should have been don in the first place.
Thanks.

utACK.

Member

jonasschnelli commented May 10, 2016

Yes. This should have been don in the first place.
Thanks.

utACK.

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens May 10, 2016

Contributor

utACK 3e2c946

Contributor

dcousens commented May 10, 2016

utACK 3e2c946

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 10, 2016

Contributor

ACK 3e2c946

Contributor

paveljanik commented May 10, 2016

ACK 3e2c946

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented May 10, 2016

utACK 3e2c946

@laanwj laanwj merged commit 3e2c946 into bitcoin:master May 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 10, 2016

Merge #8036: init: Move berkeleydb version reporting to wallet
3e2c946 init: Move berkeleydb version reporting to wallet (Wladimir J. van der Laan)

@laanwj laanwj referenced this pull request May 10, 2016

Closed

Remaining instances of ENABLE_WALLET in `libbitcoin_server.a` #7965

14 of 14 tasks complete

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8036: init: Move berkeleydb version reporting to wallet
3e2c946 init: Move berkeleydb version reporting to wallet (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8036: init: Move berkeleydb version reporting to wallet
3e2c946 init: Move berkeleydb version reporting to wallet (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8036: init: Move berkeleydb version reporting to wallet
3e2c946 init: Move berkeleydb version reporting to wallet (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment