New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: Add crypto hash benchmarks #8039

Merged
merged 1 commit into from May 12, 2016

Conversation

Projects
None yet
5 participants
@laanwj
Member

laanwj commented May 10, 2016

Add benchmarks for the cryptographic hash algorithms:

  • RIPEMD160
  • SHA1
  • SHA256
  • SHA512

Continues work on #7883.

@laanwj laanwj added the Tests label May 10, 2016

@laanwj laanwj changed the title from bench: Add hash benchmarks to bench: Add crypto hash benchmarks May 10, 2016

@laanwj laanwj referenced this pull request May 10, 2016

Closed

Add benchmarks to `bench_bitcoin` #7883

6 of 8 tasks complete
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 10, 2016

Contributor

ACK 4153366

Contributor

paveljanik commented May 10, 2016

ACK 4153366

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 10, 2016

Member

Concept ACK

Member

MarcoFalke commented May 10, 2016

Concept ACK

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 10, 2016

Member

I'd make the buffers smaller (1 MiB?). That gives both more consistent times and more relevant results (it's hard to guess that the output is seconds per 32 MiB of data).

Tested ACK otherwise.

Member

sipa commented May 10, 2016

I'd make the buffers smaller (1 MiB?). That gives both more consistent times and more relevant results (it's hard to guess that the output is seconds per 32 MiB of data).

Tested ACK otherwise.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 11, 2016

Member

I'd make the buffers smaller (1 MiB?). That gives both more consistent times and more relevant results (it's hard to guess that the output is seconds per 32 MiB of data).

Yes, good point, will change the size to 1MiB. Or even 1MB - this is not a memory benchmark, there's no deep reason why this should be in MiB.

Member

laanwj commented May 11, 2016

I'd make the buffers smaller (1 MiB?). That gives both more consistent times and more relevant results (it's hard to guess that the output is seconds per 32 MiB of data).

Yes, good point, will change the size to 1MiB. Or even 1MB - this is not a memory benchmark, there's no deep reason why this should be in MiB.

bench: Add crypto hash benchmarks
Add benchmarks for the cryptographic hash algorithms:

- RIPEMD160
- SHA1
- SHA256
- SHA512

Continues work on #7883.
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli May 11, 2016

Member

Tested ACK 32114dd

Member

jonasschnelli commented May 11, 2016

Tested ACK 32114dd

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 11, 2016

Member

Tested ACK 32114dd

Member

sipa commented May 11, 2016

Tested ACK 32114dd

@sipa sipa merged commit 32114dd into bitcoin:master May 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request May 12, 2016

Merge #8039: bench: Add crypto hash benchmarks
32114dd bench: Add crypto hash benchmarks (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8039: bench: Add crypto hash benchmarks
32114dd bench: Add crypto hash benchmarks (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8039: bench: Add crypto hash benchmarks
32114dd bench: Add crypto hash benchmarks (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8039: bench: Add crypto hash benchmarks
32114dd bench: Add crypto hash benchmarks (Wladimir J. van der Laan)

@dagurval dagurval referenced this pull request Apr 30, 2018

Merged

Benchmark cherries #408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment