New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] Fix bip9-softforks blockstore issue #8041

Merged
merged 1 commit into from May 12, 2016

Conversation

Projects
None yet
5 participants
@MarcoFalke
Member

MarcoFalke commented May 11, 2016

@sdaftuar

This should fix the issue:

bip9-softforks.py fails with BDB3028 blocks.db: unable to flush: No such file or directory

@MarcoFalke MarcoFalke added the Tests label May 11, 2016

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar May 11, 2016

Member

Just verified this fixes the issue I was seeing. Thanks!

ACK

Member

sdaftuar commented May 11, 2016

Just verified this fixes the issue I was seeing. Thanks!

ACK

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak May 11, 2016

Member

@MarcoFalke What is weird is the error only appears when running the test individually, but not as part of the pull-tester.py suite.

Member

btcdrak commented May 11, 2016

@MarcoFalke What is weird is the error only appears when running the test individually, but not as part of the pull-tester.py suite.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 11, 2016

Contributor

@MarcoFalke Can you please help me understand, what was the problem? If I understand it and am able to reproduce, I'd feel better 👍

Edit: FWIW: it never failed for me locally, either by running it individually or as part of the pull-tester.

Contributor

paveljanik commented May 11, 2016

@MarcoFalke Can you please help me understand, what was the problem? If I understand it and am able to reproduce, I'd feel better 👍

Edit: FWIW: it never failed for me locally, either by running it individually or as part of the pull-tester.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 11, 2016

Member

@paveljanik It never failed for me locally, either. But I assume the failure (print to stderr) is caused by deleting the blocks.db and not closing the db connection.

Member

MarcoFalke commented May 11, 2016

@paveljanik It never failed for me locally, either. But I assume the failure (print to stderr) is caused by deleting the blocks.db and not closing the db connection.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 11, 2016

Member

@btcdrak It should fail for both, though. The pull tester is only a convenience wrapper, so you don't have to type each command by yourself. (c.f.

subprocess.Popen((RPC_TESTS_DIR + t).split() + self.flags + port_seed,
)

Member

MarcoFalke commented May 11, 2016

@btcdrak It should fail for both, though. The pull tester is only a convenience wrapper, so you don't have to type each command by yourself. (c.f.

subprocess.Popen((RPC_TESTS_DIR + t).split() + self.flags + port_seed,
)

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak May 11, 2016

Member

I can confirm this fixes the issue of isolated runs.

ACK fa0f635

Member

btcdrak commented May 11, 2016

I can confirm this fixes the issue of isolated runs.

ACK fa0f635

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 11, 2016

Member

I have removed the changes to comptool.py, as they are not required. (Now it is a +3-0 diff; I don't think I can get it any smaller ;)

Member

MarcoFalke commented May 11, 2016

I have removed the changes to comptool.py, as they are not required. (Now it is a +3-0 diff; I don't think I can get it any smaller ;)

@laanwj laanwj merged commit fad60b3 into bitcoin:master May 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 12, 2016

Merge #8041: [qa] Fix bip9-softforks blockstore issue
fad60b3 [qa] Fix bip9-softforks blockstore issue (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1604-qaBip9Blockstore branch May 12, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8041: [qa] Fix bip9-softforks blockstore issue
fad60b3 [qa] Fix bip9-softforks blockstore issue (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8041: [qa] Fix bip9-softforks blockstore issue
fad60b3 [qa] Fix bip9-softforks blockstore issue (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8041: [qa] Fix bip9-softforks blockstore issue
fad60b3 [qa] Fix bip9-softforks blockstore issue (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment