New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt][OSX] Fix Cmd-Q / Menu Quit shutdown on OSX #8046

Merged
merged 1 commit into from May 12, 2016

Conversation

Projects
None yet
2 participants
@jonasschnelli
Member

jonasschnelli commented May 12, 2016

Most Users on OSX close applications with Cmd-Q or with "Menu"->"Quit".

There is one inconvenience during startup of Bitcoin-Qt on OSX:
If you quit the application during the splashscreen-phase, it doesn't quit the initial verification. This leads to a problem where the user needs to wait until bitcoin-qt has verified 100% of the last ~288 blocks before the application actually quits.

This PR fixes that and enables the same behavior on OSX then we have on Linux/Windows.

@laanwj

View changes

Show outdated Hide outdated src/qt/bitcoin.cpp
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli May 12, 2016

Member

Thanks @laanwj. The signal approach is much better and actually a one-line change.

Member

jonasschnelli commented May 12, 2016

Thanks @laanwj. The signal approach is much better and actually a one-line change.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 12, 2016

Member

tested ACK (well not tested on OSX but that it breaks nothing on Ubuntu) 34ebceb

Member

laanwj commented May 12, 2016

tested ACK (well not tested on OSX but that it breaks nothing on Ubuntu) 34ebceb

@jonasschnelli jonasschnelli merged commit 34ebceb into bitcoin:master May 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request May 12, 2016

Merge #8046: [Qt][OSX] Fix Cmd-Q / Menu Quit shutdown on OSX
34ebceb [Qt][OSX] Fix Cmd-Q / Menu Quit shutdown on OSX (Jonas Schnelli)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment