New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Improve Wallet encapsulation #8061

Merged
merged 2 commits into from May 25, 2016

Conversation

Projects
None yet
7 participants
@pstratem
Contributor

pstratem commented May 17, 2016

Improvements to the CWallet API which can be made without a negative performance impact.

@dcousens

This comment has been minimized.

Show comment
Hide comment
@dcousens

dcousens May 17, 2016

Contributor

utACK 380498a

On another note, CWallet is doing way too much at this point.
The movement of these functions into CWallet fall under its current responsibilities, it just simply has too many responsibilities.
No doubt we're quite the stones throw away from it following the single responsibility principle haha.

Contributor

dcousens commented May 17, 2016

utACK 380498a

On another note, CWallet is doing way too much at this point.
The movement of these functions into CWallet fall under its current responsibilities, it just simply has too many responsibilities.
No doubt we're quite the stones throw away from it following the single responsibility principle haha.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented May 17, 2016

utACK 380498a

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented May 17, 2016

utACK 380498a

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 17, 2016

Contributor

ACK 380498a

Contributor

paveljanik commented May 17, 2016

ACK 380498a

@arowser

This comment has been minimized.

Show comment
Hide comment
@arowser

arowser May 25, 2016

Contributor

Can one of the admins verify this patch?

Contributor

arowser commented May 25, 2016

Can one of the admins verify this patch?

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 25, 2016

Member

ACK, Confirmed move-only ecb9741 and 380498a.

Member

sipa commented May 25, 2016

ACK, Confirmed move-only ecb9741 and 380498a.

@sipa sipa merged commit 380498a into bitcoin:master May 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request May 25, 2016

Merge #8061: [Wallet] Improve Wallet encapsulation
380498a Move BackupWallet to CWallet::BackupWallet (Patrick Strateman)
ecb9741 Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance (Patrick Strateman)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8061: [Wallet] Improve Wallet encapsulation
380498a Move BackupWallet to CWallet::BackupWallet (Patrick Strateman)
ecb9741 Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance (Patrick Strateman)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8061: [Wallet] Improve Wallet encapsulation
380498a Move BackupWallet to CWallet::BackupWallet (Patrick Strateman)
ecb9741 Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance (Patrick Strateman)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8061: [Wallet] Improve Wallet encapsulation
380498a Move BackupWallet to CWallet::BackupWallet (Patrick Strateman)
ecb9741 Move GetAccountBalance from rpcwallet.cpp into CWallet::GetAccountBalance (Patrick Strateman)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment