New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: use slim generic image, and some fixups #8067

Merged
merged 1 commit into from Jun 10, 2016

Conversation

Projects
None yet
5 participants
@theuni
Member

theuni commented May 18, 2016

Now that caches are distinct (travis-ci/travis-ci#4393), we can use the Travis minimal image. The minimal image should take less time to setup and lead to quicker builds.

Also addressed while I'm in here:

  • No need to delete the broken google-chrome repo in the minimal image
  • Set the hostname to work-around an openjdk bug
  • Remove the non-functional apt-cache option
  • Remove useless message at completion
  • Install jre where the java tests are run
  • 'make check' in parallel, since the log will take care of clean output
  • 'make check' verbose, so that test failure causes aren't hidden
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 18, 2016

Member

Concept ACK.

Travis failure is extremely scary:

02:08:15 1 H2FullPrunedBlockStore.<init>: org.h2.Driver loaded. 
*** buffer overflow detected ***: /usr/bin/java terminated
Member

laanwj commented May 18, 2016

Concept ACK.

Travis failure is extremely scary:

02:08:15 1 H2FullPrunedBlockStore.<init>: org.h2.Driver loaded. 
*** buffer overflow detected ***: /usr/bin/java terminated
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake May 18, 2016

Member

@laanwj The use of the hostname addon is meant to prevent that issue, so the workaround might not be working as expected. More info about it can be found here

Concept ACK, glad to see the caching issue finally sorted.

Member

fanquake commented May 18, 2016

@laanwj The use of the hostname addon is meant to prevent that issue, so the workaround might not be working as expected. More info about it can be found here

Concept ACK, glad to see the caching issue finally sorted.

@MarcoFalke

View changes

Show outdated Hide outdated .travis.yml
travis: use slim generic image, and some fixups
Now that caches are distinct (travis-ci/travis-ci#4393),
we can use the Travis minimal image.
The minimal image should take less time to setup and lead to quicker builds.

Also addressed while I'm in here:
- No need to delete the broken google-chrome repo in the minimal image
- Set the hostname to work-around an openjdk bug
- Remove the non-functional apt-cache option
- Remove useless message at completion
- Install jre where the java tests are run
@arowser

This comment has been minimized.

Show comment
Hide comment
@arowser

arowser May 25, 2016

Contributor

Can one of the admins verify this patch?

Contributor

arowser commented May 25, 2016

Can one of the admins verify this patch?

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 26, 2016

Member

Looks like the workaround for the work-around is still failing travis :(

Member

laanwj commented May 26, 2016

Looks like the workaround for the work-around is still failing travis :(

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 6, 2016

Member

Tried to retrigger travis, still fails

Member

laanwj commented Jun 6, 2016

Tried to retrigger travis, still fails

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jun 9, 2016

Member

Ready for review now, the upstream issue has been resolved.

Member

theuni commented Jun 9, 2016

Ready for review now, the upstream issue has been resolved.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj
Member

laanwj commented Jun 10, 2016

@laanwj laanwj merged commit 2ca8962 into bitcoin:master Jun 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 10, 2016

Merge #8067: travis: use slim generic image, and some fixups
2ca8962 travis: use slim generic image, and some fixups (Cory Fields)
@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jun 10, 2016

Member

Post merge utACK 2ca8962

Member

fanquake commented Jun 10, 2016

Post merge utACK 2ca8962

@MarcoFalke MarcoFalke referenced this pull request Jul 5, 2016

Merged

[travis] Update SDK_URL #8304

@schinzelh schinzelh referenced this pull request Oct 20, 2017

Closed

[WIP] Update build system to Bitcoin 0.13.2 #1692

22 of 24 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment