New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use mempool for GETDATA for tx accepted after the last mempool req. #8080

Merged
merged 1 commit into from May 31, 2016

Conversation

Projects
None yet
7 participants
@gmaxwell
Member

gmaxwell commented May 21, 2016

The ability to GETDATA a transaction which has not (yet) been relayed
is a privacy loss vector.

The use of the mempool for this was added as part of the mempool p2p
message and is only needed to fetch transactions returned by it.

@jonasschnelli

View changes

Show outdated Hide outdated src/main.cpp
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli May 21, 2016

Member

utACK ef6c31142e52e56af93486986319f5499e72c7df

Member

jonasschnelli commented May 21, 2016

utACK ef6c31142e52e56af93486986319f5499e72c7df

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 21, 2016

Member

utACK ef6c31142e52e56af93486986319f5499e72c7df

Member

sipa commented May 21, 2016

utACK ef6c31142e52e56af93486986319f5499e72c7df

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell May 23, 2016

Member

Changed the variable name and added a comment in response to Petertodd's comments, also avoided the nested if per jonasschnelli's comments.

Member

gmaxwell commented May 23, 2016

Changed the variable name and added a comment in response to Petertodd's comments, also avoided the nested if per jonasschnelli's comments.

@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd May 23, 2016

Contributor

utACK 8e9890f

Contributor

petertodd commented May 23, 2016

utACK 8e9890f

@paveljanik

View changes

Show outdated Hide outdated src/net.h
@paveljanik

View changes

Show outdated Hide outdated src/txmempool.cpp
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 24, 2016

Contributor

Concept ACK.

Contributor

paveljanik commented May 24, 2016

Concept ACK.

@arowser

This comment has been minimized.

Show comment
Hide comment
@arowser

arowser May 25, 2016

Contributor

Can one of the admins verify this patch?

Contributor

arowser commented May 25, 2016

Can one of the admins verify this patch?

Do not use mempool for GETDATA for tx accepted after the last mempool…
… req.

The ability to GETDATA a transaction which has not (yet) been relayed
 is a privacy loss vector.

The use of the mempool for this was added as part of the mempool p2p
 message and is only needed to fetch transactions returned by it.

@sipa sipa referenced this pull request May 26, 2016

Merged

Addrman offline attempts #8065

@laanwj laanwj merged commit 7e908c7 into bitcoin:master May 31, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request May 31, 2016

Merge #8080: Do not use mempool for GETDATA for tx accepted after the…
… last mempool req.

7e908c7 Do not use mempool for GETDATA for tx accepted after the last mempool req. (Gregory Maxwell)

@sipa sipa referenced this pull request Jun 13, 2016

Closed

Segregated witness #7910

5 of 7 tasks complete

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8080: Do not use mempool for GETDATA for tx accepted after the…
… last mempool req.

7e908c7 Do not use mempool for GETDATA for tx accepted after the last mempool req. (Gregory Maxwell)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8080: Do not use mempool for GETDATA for tx accepted after the…
… last mempool req.

7e908c7 Do not use mempool for GETDATA for tx accepted after the last mempool req. (Gregory Maxwell)

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017

Merge #8080: Do not use mempool for GETDATA for tx accepted after the…
… last mempool req.

7e908c7 Do not use mempool for GETDATA for tx accepted after the last mempool req. (Gregory Maxwell)

codablock added a commit to codablock/dash that referenced this pull request Feb 7, 2018

Update timeLastMempoolReq when responding to MEMPOOL request
This should have been part of the Bitcoin #8080 backporting but was missed
due to manual conflict resolution.

UdjinM6 added a commit to dashpay/dash that referenced this pull request Feb 8, 2018

Update timeLastMempoolReq when responding to MEMPOOL request (#1904)
This should have been part of the Bitcoin #8080 backporting but was missed
due to manual conflict resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment