New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test framework: only cleanup on successful test runs #8095

Merged
merged 1 commit into from May 25, 2016

Conversation

Projects
None yet
6 participants
@sdaftuar
Member

sdaftuar commented May 24, 2016

Don't cleanup the datadir's on test failure.

I hope that this should make it easier to debug rare-failing tests, as we'll at least have the debug.log's available to go through.

@MarcoFalke: After this, we could perhaps add to the rpc-tests.py script some functionality to tail the last few hundred lines of debug.log for each node if a test fails, so that if a job fails in travis, we'll have more info to look at?

@jtimon

This comment has been minimized.

Show comment
Hide comment
@jtimon

jtimon May 24, 2016

Member

ACK

Member

jtimon commented May 24, 2016

ACK

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik May 24, 2016

Contributor

ACK 64fc92f

Contributor

paveljanik commented May 24, 2016

ACK 64fc92f

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 24, 2016

Member

Concept ACK. Wouldn't it make sense to also print("Not cleaning up dir %s" % self.options.tmpdir)?

Tailing the debug.log from rpc_tests.py makes sense, but would at least require #8098.

Member

MarcoFalke commented May 24, 2016

Concept ACK. Wouldn't it make sense to also print("Not cleaning up dir %s" % self.options.tmpdir)?

Tailing the debug.log from rpc_tests.py makes sense, but would at least require #8098.

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak May 24, 2016

Member

utACK 64fc92f

Member

btcdrak commented May 24, 2016

utACK 64fc92f

@jonasschnelli jonasschnelli added the Tests label May 24, 2016

@jtimon

This comment has been minimized.

Show comment
Hide comment
@jtimon

jtimon May 25, 2016

Member

@arowser why are you asking the same question in so many random PRs?

This is disruptive or development and annoying. Please, stop.

Member

jtimon commented May 25, 2016

@arowser why are you asking the same question in so many random PRs?

This is disruptive or development and annoying. Please, stop.

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar May 25, 2016

Member

@MarcoFalke Updated with the print statement as suggested.

Member

sdaftuar commented May 25, 2016

@MarcoFalke Updated with the print statement as suggested.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented May 25, 2016

utACK 1ad9339

@jtimon

This comment has been minimized.

Show comment
Hide comment
@jtimon
Member

jtimon commented May 25, 2016

ACK 1ad9339

@MarcoFalke MarcoFalke merged commit 1ad9339 into bitcoin:master May 25, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

MarcoFalke added a commit that referenced this pull request May 25, 2016

Merge #8095: Test framework: only cleanup on successful test runs
1ad9339 Test framework: only cleanup on successful test runs (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge bitcoin#8095: Test framework: only cleanup on successful test runs
1ad9339 Test framework: only cleanup on successful test runs (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#8095: Test framework: only cleanup on successful test runs
1ad9339 Test framework: only cleanup on successful test runs (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge bitcoin#8095: Test framework: only cleanup on successful test runs
1ad9339 Test framework: only cleanup on successful test runs (Suhas Daftuar)

@dagurval dagurval referenced this pull request Feb 1, 2018

Merged

QA cherries #319

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request Mar 12, 2018

Partial port of XT PR BitcoinUnlimited#319 from dagurval/qa-cherries
Core QA cherries

bitcoin/bitcoin#8047 - [qa] test_framework: Set wait-timeout for bitcoind procs
bitcoin/bitcoin#8095 - Test framework: only cleanup on successful test runs
bitcoin/bitcoin#8214 - [qa] mininode: fail on send_message instead of silent return

@sickpig sickpig referenced this pull request Mar 12, 2018

Merged

QA Core ports #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment