New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] test_framework: Append portseed to tmpdir #8098

Merged
merged 1 commit into from May 27, 2016

Conversation

Projects
None yet
3 participants
@MarcoFalke
Member

MarcoFalke commented May 24, 2016

This makes it possible to specify a tmpdir while running tests in
parallel.

[qa] test_framework: Append portseed to tmpdir
This makes it possible to specify a tmpdir while running tests in
parallel
@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar May 25, 2016

Member

How about a '.' in the name to separate dirname and port_seed, rather than a '/' for a new directory? Seems like tab-completion would work better that way.

Member

sdaftuar commented May 25, 2016

How about a '.' in the name to separate dirname and port_seed, rather than a '/' for a new directory? Seems like tab-completion would work better that way.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 26, 2016

Member

@sdaftuar Can you explain how this helps tab-completion? I fail to see the difference in the '.' vs '/'.

Also, this would mean to adjust the --tmpdir help to help="Path prefix for datadirs. (portseed is appended to the prefix)".

Member

MarcoFalke commented May 26, 2016

@sdaftuar Can you explain how this helps tab-completion? I fail to see the difference in the '.' vs '/'.

Also, this would mean to adjust the --tmpdir help to help="Path prefix for datadirs. (portseed is appended to the prefix)".

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar May 26, 2016

Member

@MarcoFalke Ah I hadn't thought about the --tmpdir argument requiring us to use space inside that directory tree, that's a fair point. I was just thinking that I have to press [tab] one extra time to tab-complete to a subdirectory, maybe that's unique to my shell/environment, but not a big deal.

ACK

Member

sdaftuar commented May 26, 2016

@MarcoFalke Ah I hadn't thought about the --tmpdir argument requiring us to use space inside that directory tree, that's a fair point. I was just thinking that I have to press [tab] one extra time to tab-complete to a subdirectory, maybe that's unique to my shell/environment, but not a big deal.

ACK

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 26, 2016

Member

Concept ACK

Member

sipa commented May 26, 2016

Concept ACK

@MarcoFalke MarcoFalke merged commit fa57b0c into bitcoin:master May 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request May 27, 2016

Merge #8098: [qa] test_framework: Append portseed to tmpdir
fa57b0c [qa] test_framework: Append portseed to tmpdir (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1605-qatmpdir branch May 27, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8098: [qa] test_framework: Append portseed to tmpdir
fa57b0c [qa] test_framework: Append portseed to tmpdir (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8098: [qa] test_framework: Append portseed to tmpdir
fa57b0c [qa] test_framework: Append portseed to tmpdir (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8098: [qa] test_framework: Append portseed to tmpdir
fa57b0c [qa] test_framework: Append portseed to tmpdir (MarcoFalke)

@dagurval dagurval referenced this pull request Feb 1, 2018

Merged

QA cherries #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment