New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add timeout to sync_blocks() and sync_mempools() #8104

Merged
merged 1 commit into from May 29, 2016

Conversation

Projects
None yet
5 participants
@sdaftuar
Member

sdaftuar commented May 26, 2016

Previously these functions would infinitely loop if sync failed;
now they have a default timeout of 60 seconds, after which an
AssertionError is raised.

sync_blocks() has also been improved and now compares the tip
hash of each node, rather than just using block count.

Tests: add timeout to sync_blocks() and sync_mempools()
Previously these functions would infinitely loop if sync failed;
now they have a default timeout of 60 seconds, after which an
AssertionError is raised.

sync_blocks() has also been improved and now compares the tip
hash of each node, rather than just using block count.

@MarcoFalke MarcoFalke added the Tests label May 26, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke May 26, 2016

Member

Thanks! Concept ACK.

Member

MarcoFalke commented May 26, 2016

Thanks! Concept ACK.

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa May 26, 2016

Member

utACK e871f83

Member

sipa commented May 26, 2016

utACK e871f83

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented May 27, 2016

utACK e871f83

@MarcoFalke MarcoFalke merged commit e871f83 into bitcoin:master May 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request May 29, 2016

Merge #8104: Tests: add timeout to sync_blocks() and sync_mempools()
e871f83 Tests: add timeout to sync_blocks() and sync_mempools() (Suhas Daftuar)
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj May 30, 2016

Member

sync_blocks() has also been improved and now compares the tiphash of each node

Good idea

Member

laanwj commented May 30, 2016

sync_blocks() has also been improved and now compares the tiphash of each node

Good idea

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8104: Tests: add timeout to sync_blocks() and sync_mempools()
e871f83 Tests: add timeout to sync_blocks() and sync_mempools() (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8104: Tests: add timeout to sync_blocks() and sync_mempools()
e871f83 Tests: add timeout to sync_blocks() and sync_mempools() (Suhas Daftuar)

codablock added a commit to codablock/dash that referenced this pull request Dec 21, 2017

Merge #8104: Tests: add timeout to sync_blocks() and sync_mempools()
e871f83 Tests: add timeout to sync_blocks() and sync_mempools() (Suhas Daftuar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment