New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RPC console auto completer #8129

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
4 participants
@UdjinM6
Contributor

UdjinM6 commented May 31, 2016

PR #7772 is not enough to fix the issue with QCompleter.

Steps to reproduce the issue in current build: open Debug window, go to Console, close it, open it again, start writing some rpc command and try to pick it from the list using arrow keys, hit Enter. Note that edit field is not being cleared as it should be, works on second try only (i.e. same as before).

Using event filter to forward messages from autoCompleter popup to lineEdit instead of using connect method solves the issue.

@jonasschnelli jonasschnelli added the GUI label Jun 1, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 1, 2016

Member

Concept ACK 16698cb

Member

MarcoFalke commented Jun 1, 2016

Concept ACK 16698cb

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 1, 2016

Contributor

Thanks for fixing this completely!

ACK 16698cb

Contributor

paveljanik commented Jun 1, 2016

Thanks for fixing this completely!

ACK 16698cb

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 2, 2016

Member

Tested ACK 16698cb

Member

jonasschnelli commented Jun 2, 2016

Tested ACK 16698cb

@jonasschnelli jonasschnelli merged commit 16698cb into bitcoin:master Jun 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Jun 2, 2016

Merge #8129: Fix RPC console auto completer
16698cb PR #7772 is not enough to fix the issue with QCompleter, use event filter instead of `connect` (UdjinM6)

@UdjinM6 UdjinM6 deleted the UdjinM6:fixRPCAutoCompleter_bitcoin branch Jun 20, 2016

kyuupichan referenced this pull request in kyuupichan/BitcoinUnlimited Mar 12, 2017

Merge #8129: Fix RPC console auto completer
16698cb PR #7772 is not enough to fix the issue with QCompleter, use event filter instead of `connect` (UdjinM6)

cddjr referenced this pull request in cddjr/BitcoinUnlimited Apr 6, 2017

Merge #8129: Fix RPC console auto completer
16698cb PR #7772 is not enough to fix the issue with QCompleter, use event filter instead of `connect` (UdjinM6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment