New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CWallet API with new GetAccountPubkey function. #8142

Merged
merged 1 commit into from Jun 6, 2016

Conversation

Projects
None yet
4 participants
@pstratem
Contributor

pstratem commented Jun 3, 2016

Remove one more caller that is passing CWalletDB

@MarcoFalke MarcoFalke added the Wallet label Jun 3, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 3, 2016

Member

Travis didn't fetch this one. Mind to do a "null-rebase" and force-push?

Member

MarcoFalke commented Jun 3, 2016

Travis didn't fetch this one. Mind to do a "null-rebase" and force-push?

@pstratem

This comment has been minimized.

Show comment
Hide comment
@pstratem

pstratem Jun 3, 2016

Contributor
Contributor

pstratem commented Jun 3, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 3, 2016

Member

Concept ACK

There does seem to be a pattern lately to move more and more code to the CWallet class, and we do need to split that up at some point, but I agree that these implementation details don't belong in the RPC code and that this is better locking-wise.

Member

laanwj commented Jun 3, 2016

Concept ACK

There does seem to be a pattern lately to move more and more code to the CWallet class, and we do need to split that up at some point, but I agree that these implementation details don't belong in the RPC code and that this is better locking-wise.

@pstratem

This comment has been minimized.

Show comment
Hide comment
@pstratem

pstratem Jun 3, 2016

Contributor

@laanwj I'm going to be working on improving the wallet in general but that's very difficult to do when there's code all over the place.

This is just the logical first step.

Contributor

pstratem commented Jun 3, 2016

@laanwj I'm going to be working on improving the wallet in general but that's very difficult to do when there's code all over the place.

This is just the logical first step.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 3, 2016

Member

utACK 8eb28b6

Member

MarcoFalke commented Jun 3, 2016

utACK 8eb28b6

Improve CWallet API with new GetAccountPubkey function.
Remove one more caller that is passing CWalletDB.
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 6, 2016

Member

Checked move-only, utACK 8eb28b6

Member

laanwj commented Jun 6, 2016

Checked move-only, utACK 8eb28b6

@laanwj laanwj merged commit 152ab23 into bitcoin:master Jun 6, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

laanwj added a commit that referenced this pull request Jun 6, 2016

Merge #8142: Improve CWallet API with new GetAccountPubkey function.
152ab23 Improve CWallet API  with new GetAccountPubkey function. (Patrick Strateman)
@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 6, 2016

Member

Posthumous move-only utACK 152ab23

For reference:

git diff -w --patience --word-diff=color 152ab23~:src/wallet/rpcwallet.cpp 152ab23:src/wallet/wallet.cpp
Member

sipa commented Jun 6, 2016

Posthumous move-only utACK 152ab23

For reference:

git diff -w --patience --word-diff=color 152ab23~:src/wallet/rpcwallet.cpp 152ab23:src/wallet/wallet.cpp

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8142: Improve CWallet API with new GetAccountPubkey function.
152ab23 Improve CWallet API  with new GetAccountPubkey function. (Patrick Strateman)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8142: Improve CWallet API with new GetAccountPubkey function.
152ab23 Improve CWallet API  with new GetAccountPubkey function. (Patrick Strateman)

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017

Merge #8142: Improve CWallet API with new GetAccountPubkey function.
152ab23 Improve CWallet API  with new GetAccountPubkey function. (Patrick Strateman)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment