New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop vAddrToSend after sending big addr message #8154

Merged
merged 1 commit into from Jun 9, 2016

Conversation

Projects
None yet
4 participants
@kazcw
Contributor

kazcw commented Jun 6, 2016

We send a newly-accepted peer a 1000-entry addr message, and then only use
vAddrToSend for small messages. Deallocate vAddrToSend after it's been used for
the big message to save about 40 kB per connected inbound peer.

@sipa

View changes

Show outdated Hide outdated src/main.cpp
drop vAddrToSend after sending big addr message
We send a newly-accepted peer a 1000-entry addr message, and then only use
vAddrToSend for small messages. Deallocate vAddrToSend after it's been used for
the big message to save about 40 kB per connected inbound peer.

@jonasschnelli jonasschnelli added the P2P label Jun 7, 2016

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 7, 2016

Member

utACK d3d02d5

Member

sipa commented Jun 7, 2016

utACK d3d02d5

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 9, 2016

Member

utACK d3d02d5

Member

laanwj commented Jun 9, 2016

utACK d3d02d5

@laanwj laanwj merged commit d3d02d5 into bitcoin:master Jun 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 9, 2016

Merge #8154: drop vAddrToSend after sending big addr message
d3d02d5 drop vAddrToSend after sending big addr message (Kaz Wesley)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8154: drop vAddrToSend after sending big addr message
d3d02d5 drop vAddrToSend after sending big addr message (Kaz Wesley)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8154: drop vAddrToSend after sending big addr message
d3d02d5 drop vAddrToSend after sending big addr message (Kaz Wesley)

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017

Merge #8154: drop vAddrToSend after sending big addr message
d3d02d5 drop vAddrToSend after sending big addr message (Kaz Wesley)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment