New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] Fix createrawtx sequence number unsigned int parsing #8171

Merged
merged 1 commit into from Jun 16, 2016

Conversation

Projects
None yet
5 participants
@jonasschnelli
Member

jonasschnelli commented Jun 8, 2016

Another cleanup PR for #7957.
The sequence number input over RPC was parsed with ParseInt32 and inputs > 0x7FFFFFFF where rejected.

This PR reads inputs with get_int64 and does a range check (>=0 <= 0xFFFFFFFF).

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 9, 2016

Member

utACK 6fa950a (but the added tests are sufficient)

Member

laanwj commented Jun 9, 2016

utACK 6fa950a (but the added tests are sufficient)

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 9, 2016

Contributor

ACK 6fa950a

Contributor

paveljanik commented Jun 9, 2016

ACK 6fa950a

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Jun 15, 2016

Member

ACK

Member

gmaxwell commented Jun 15, 2016

ACK

@MarcoFalke MarcoFalke added this to the 0.13.0 milestone Jun 15, 2016

@laanwj laanwj merged commit 6fa950a into bitcoin:master Jun 16, 2016

laanwj added a commit that referenced this pull request Jun 16, 2016

Merge #8171: [RPC] Fix createrawtx sequence number unsigned int parsing
6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8171: [RPC] Fix createrawtx sequence number unsigned int parsing
6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8171: [RPC] Fix createrawtx sequence number unsigned int parsing
6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8171: [RPC] Fix createrawtx sequence number unsigned int parsing
6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8171: [RPC] Fix createrawtx sequence number unsigned int parsing
6fa950a [RPC] Fix createrawtx sequence number unsigned int parsing (Jonas Schnelli)

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request May 4, 2018

Port XT PR #403: [RPC][Bitcoin-TX] Add support for sequence number
bitcoin/bitcoin#7957 - [RPC][Bitcoin-TX] Add support for sequence number
bitcoin/bitcoin#8164 - [Bitcoin-Tx] fix missing test fixtures, fix 32bit atoi issue
bitcoin/bitcoin#8171 - [RPC] Fix createrawtx sequence number unsigned int parsing

[RPC][Bitcoin-TX] Add support for sequence number

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request May 9, 2018

Port XT PR #403: [RPC][Bitcoin-TX] Add support for sequence number
bitcoin/bitcoin#7957 - [RPC][Bitcoin-TX] Add support for sequence number
bitcoin/bitcoin#8164 - [Bitcoin-Tx] fix missing test fixtures, fix 32bit atoi issue
bitcoin/bitcoin#8171 - [RPC] Fix createrawtx sequence number unsigned int parsing

[RPC][Bitcoin-TX] Add support for sequence number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment