New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SipHash for node eviction (cont'd) #8173

Merged
merged 5 commits into from Jun 8, 2016

Conversation

Projects
None yet
7 participants
@laanwj
Member

laanwj commented Jun 8, 2016

Add full test vectors from spec, test per byte and per 8 bytes.

Builds on #8086 (as it adds per-byte hashing).

@laanwj laanwj added the Tests label Jun 8, 2016

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 8, 2016

Member

utACK eebc232

Member

sipa commented Jun 8, 2016

utACK eebc232

@sipa sipa referenced this pull request Jun 8, 2016

Closed

Use SipHash for node eviction #8086

@instagibbs

This comment has been minimized.

Show comment
Hide comment
@instagibbs

instagibbs Jun 8, 2016

Member

May want to re-title this PR

Member

instagibbs commented Jun 8, 2016

May want to re-title this PR

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 8, 2016

Member

The original had grown in scope anyway, it now does:

  • Extend the SipHash implementation
  • Improved comments
  • Added tests
  • Switched to thread-safe random seed initializers
  • Switch node eviction to use siphash
Member

sipa commented Jun 8, 2016

The original had grown in scope anyway, it now does:

  • Extend the SipHash implementation
  • Improved comments
  • Added tests
  • Switched to thread-safe random seed initializers
  • Switch node eviction to use siphash

@laanwj laanwj changed the title from test: Add more test vectors for siphash to Use SipHash for node eviction (cont'd) Jun 8, 2016

@NicolasDorier

This comment has been minimized.

Show comment
Hide comment
@NicolasDorier

NicolasDorier Jun 8, 2016

Member

tACK on the purely Siphash part (reimplemented this PR tests included into NBitcoin successfully on MetacoSA/NBitcoin@c915829)

Member

NicolasDorier commented Jun 8, 2016

tACK on the purely Siphash part (reimplemented this PR tests included into NBitcoin successfully on MetacoSA/NBitcoin@c915829)

@sipa sipa merged commit eebc232 into bitcoin:master Jun 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request Jun 8, 2016

Merge #8173: Use SipHash for node eviction (cont'd)
eebc232 test: Add more test vectors for siphash (Wladimir J. van der Laan)
8884830 Use C++11 thread-safe static initializers (Pieter Wuille)
c31b24f Use 64-bit SipHash of netgroups in eviction (Pieter Wuille)
9bf156b Support SipHash with arbitrary byte writes (Pieter Wuille)
053930f Avoid recalculating vchKeyedNetGroup in eviction logic. (Patrick Strateman)
@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 9, 2016

Member
Member

sipa commented Jun 9, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 9, 2016

Member

@sipa it's not clear who or what you're replying to

In any case, it was time to merge this, there were no concrete concerns left.

Member

laanwj commented Jun 9, 2016

@sipa it's not clear who or what you're replying to

In any case, it was time to merge this, there were no concrete concerns left.

@MarcoFalke MarcoFalke added P2P and removed Tests labels Jun 9, 2016

@kazcw kazcw referenced this pull request Jun 10, 2016

Merged

p2p: Begin encapsulation #8085

@rebroad

This comment has been minimized.

Show comment
Hide comment
@rebroad

rebroad Aug 9, 2016

Contributor

What is a SipHash?

Contributor

rebroad commented Aug 9, 2016

What is a SipHash?

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa
Member

sipa commented Aug 9, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8173: Use SipHash for node eviction (cont'd)
eebc232 test: Add more test vectors for siphash (Wladimir J. van der Laan)
8884830 Use C++11 thread-safe static initializers (Pieter Wuille)
c31b24f Use 64-bit SipHash of netgroups in eviction (Pieter Wuille)
9bf156b Support SipHash with arbitrary byte writes (Pieter Wuille)
053930f Avoid recalculating vchKeyedNetGroup in eviction logic. (Patrick Strateman)

codablock added a commit to codablock/dash that referenced this pull request Sep 27, 2017

Merge #8173: Use SipHash for node eviction (cont'd)
eebc232 test: Add more test vectors for siphash (Wladimir J. van der Laan)
8884830 Use C++11 thread-safe static initializers (Pieter Wuille)
c31b24f Use 64-bit SipHash of netgroups in eviction (Pieter Wuille)
9bf156b Support SipHash with arbitrary byte writes (Pieter Wuille)
053930f Avoid recalculating vchKeyedNetGroup in eviction logic. (Patrick Strateman)

codablock added a commit to codablock/dash that referenced this pull request Oct 12, 2017

Use C++11 thread-safe static initializers in coins.h/coins.cpp
Taken from Bitcoin #8173/888483098e60f2a944f1d246bbfec4d14a2975f8

Needed to align code for upcoming per-utxo backports.

codablock added a commit to codablock/dash that referenced this pull request Oct 19, 2017

Use C++11 thread-safe static initializers in coins.h/coins.cpp
Taken from Bitcoin #8173/888483098e60f2a944f1d246bbfec4d14a2975f8

Needed to align code for upcoming per-utxo backports.

UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Nov 8, 2017

Use C++11 thread-safe static initializers in coins.h/coins.cpp
Taken from Bitcoin #8173/888483098e60f2a944f1d246bbfec4d14a2975f8

Needed to align code for upcoming per-utxo backports.

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017

Merge #8173: Use SipHash for node eviction (cont'd)
eebc232 test: Add more test vectors for siphash (Wladimir J. van der Laan)
8884830 Use C++11 thread-safe static initializers (Pieter Wuille)
c31b24f Use 64-bit SipHash of netgroups in eviction (Pieter Wuille)
9bf156b Support SipHash with arbitrary byte writes (Pieter Wuille)
053930f Avoid recalculating vchKeyedNetGroup in eviction logic. (Patrick Strateman)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment