New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Get rid of `CLIENT_DATE` #8181

Merged
merged 1 commit into from Jun 10, 2016

Conversation

Projects
None yet
5 participants
@laanwj
Member

laanwj commented Jun 9, 2016

Putting the build date in the executable is a practice that has no place in these days, now that deterministic building is increasingly common.

Continues #7732 which did this for the GUI.

@laanwj laanwj added the Build system label Jun 9, 2016

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 9, 2016

Contributor

utACK f6e201d

Contributor

paveljanik commented Jun 9, 2016

utACK f6e201d

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 9, 2016

Member

Concept ACK f6e201d

Member

MarcoFalke commented Jun 9, 2016

Concept ACK f6e201d

build: Get rid of `CLIENT_DATE`
Putting the build date in the executable is a practice that has no place
in these days, now that deterministic building is increasingly common.

Continues #7732 which did this for the GUI.
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 9, 2016

Member

Updated the commit to also remove CLIENT_DATE logic from genbuild.sh (thanks @MarcoFalke)

Member

laanwj commented Jun 9, 2016

Updated the commit to also remove CLIENT_DATE logic from genbuild.sh (thanks @MarcoFalke)

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Jun 9, 2016

utACK d096d22

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 9, 2016

Contributor

ACK d096d22

Contributor

paveljanik commented Jun 9, 2016

ACK d096d22

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 9, 2016

Member

utACK d096d22

Member

sipa commented Jun 9, 2016

utACK d096d22

@theuni

This comment has been minimized.

Show comment
Hide comment
@theuni

theuni Jun 9, 2016

Member

ut ACK d096d22

Member

theuni commented Jun 9, 2016

ut ACK d096d22

@laanwj laanwj merged commit d096d22 into bitcoin:master Jun 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 10, 2016

Merge #8181: build: Get rid of `CLIENT_DATE`
d096d22 build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge bitcoin#8181: build: Get rid of `CLIENT_DATE`
d096d22 build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge bitcoin#8181: build: Get rid of `CLIENT_DATE`
d096d22 build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan)

codablock added a commit to codablock/dash that referenced this pull request Dec 22, 2017

Merge bitcoin#8181: build: Get rid of `CLIENT_DATE`
d096d22 build: Get rid of `CLIENT_DATE` (Wladimir J. van der Laan)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment