New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Sync ax_pthread with upstream draft4 #8198

Merged
merged 1 commit into from Jun 14, 2016

Conversation

Projects
None yet
4 participants
@fanquake
Member

fanquake commented Jun 13, 2016

Draft4 of ax_pthread has been available since February, and is the current version available from gnu.org. It fixes an issue on FreeBSD, so sync our version with upstream.

Whitespaceless diff

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 13, 2016

Contributor

The non-shitespaced diff 0e209f9?w=0 shows that only serial is bumped up and freebsd removed from some condition.

utACK 0e209f9

But: nobody reported this issue to us anyway. But: why not... I think it makes sense only if we have an issue for such "syncs".

Contributor

paveljanik commented Jun 13, 2016

The non-shitespaced diff 0e209f9?w=0 shows that only serial is bumped up and freebsd removed from some condition.

utACK 0e209f9

But: nobody reported this issue to us anyway. But: why not... I think it makes sense only if we have an issue for such "syncs".

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Jun 14, 2016

Member

Yes I'm not sure why there is such a whitespace difference between the actual draft4 and the version available on gnu.org. I guess we could just include the important changes?

Member

fanquake commented Jun 14, 2016

Yes I'm not sure why there is such a whitespace difference between the actual draft4 and the version available on gnu.org. I guess we could just include the important changes?

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Jun 14, 2016

utACK 0e209f9

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 14, 2016

Member

But: nobody reported this issue to us anyway. But: why not... I think it makes sense only if we have an issue for such "syncs".

Agree, I don't think we should do this too often, especially not if the specific issue isn't reported to us.

Maybe it would makes sense to schedule an update of the .m4s once per (major) release or so? And group them together in one pull. To include it in the per-release actions at the top of the release process?

Apart from that, it's harmless (the actual diff is minimal and obvious), so utACK 0e209f9

Member

laanwj commented Jun 14, 2016

But: nobody reported this issue to us anyway. But: why not... I think it makes sense only if we have an issue for such "syncs".

Agree, I don't think we should do this too often, especially not if the specific issue isn't reported to us.

Maybe it would makes sense to schedule an update of the .m4s once per (major) release or so? And group them together in one pull. To include it in the per-release actions at the top of the release process?

Apart from that, it's harmless (the actual diff is minimal and obvious), so utACK 0e209f9

@laanwj laanwj merged commit 0e209f9 into bitcoin:master Jun 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 14, 2016

Merge #8198: [trivial] Sync ax_pthread with upstream draft4
0e209f9 [trivial] Sync ax_pthread with upstream draft (fanquake)

@fanquake fanquake deleted the fanquake:sync-pthread branch Jun 22, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8198: [trivial] Sync ax_pthread with upstream draft4
0e209f9 [trivial] Sync ax_pthread with upstream draft (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8198: [trivial] Sync ax_pthread with upstream draft4
0e209f9 [trivial] Sync ax_pthread with upstream draft (fanquake)

@schinzelh schinzelh referenced this pull request Oct 23, 2017

Closed

[WIP] Update build system to Bitcoin 0.13.2 #1692

22 of 24 tasks complete

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8198: [trivial] Sync ax_pthread with upstream draft4
0e209f9 [trivial] Sync ax_pthread with upstream draft (fanquake)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8198: [trivial] Sync ax_pthread with upstream draft4
0e209f9 [trivial] Sync ax_pthread with upstream draft (fanquake)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment