New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify documentation for running a tor node #8203

Merged
merged 1 commit into from Jun 20, 2016

Conversation

Projects
None yet
4 participants
@nathaniel-mahieu
Contributor

nathaniel-mahieu commented Jun 14, 2016

Previous wording suggested that no additional setup was required for a tor hidden service to be created.

Discussed here: #8145

@petertodd

View changes

Show outdated Hide outdated doc/tor.md

@jonasschnelli jonasschnelli added the P2P label Jun 15, 2016

This new feature is enabled by default if Bitcoin Core is listening, and
a connection to Tor can be made. It can be configured with the `-listenonion`,
`-torcontrol` and `-torpassword` settings. To show verbose debugging
information, pass `-debug=tor`.
Connecting to Tor's control socket API requires one of two authentication methods to be

This comment has been minimized.

@laanwj

laanwj Jun 16, 2016

Member

I'd reword this a bit - cookie authentication is by far the most straightforward (even automatic) if bitcoin core has access to tor's cookie file. This is the case on Windows with Tor Browser Bundle, for example. If not, then extra work is needed to set it up.

@laanwj

laanwj Jun 16, 2016

Member

I'd reword this a bit - cookie authentication is by far the most straightforward (even automatic) if bitcoin core has access to tor's cookie file. This is the case on Windows with Tor Browser Bundle, for example. If not, then extra work is needed to set it up.

This comment has been minimized.

@nathaniel-mahieu

nathaniel-mahieu Jun 16, 2016

Contributor

Removed the opinion on simplicity.

@nathaniel-mahieu

nathaniel-mahieu Jun 16, 2016

Contributor

Removed the opinion on simplicity.

@petertodd

View changes

Show outdated Hide outdated doc/tor.md
@laanwj

View changes

Show outdated Hide outdated doc/tor.md
Clarify documentation for running a tor node
Previous wording suggested that no additional setup was required for a
tor hidden service to be created.
@petertodd

This comment has been minimized.

Show comment
Hide comment
@petertodd

petertodd Jun 18, 2016

Contributor

utACK 9e3ec74

Contributor

petertodd commented Jun 18, 2016

utACK 9e3ec74

@laanwj laanwj merged commit 9e3ec74 into bitcoin:master Jun 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 20, 2016

Merge #8203: Clarify documentation for running a tor node
9e3ec74 Clarify documentation for running a tor node (Nathaniel Mahieu)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8203: Clarify documentation for running a tor node
9e3ec74 Clarify documentation for running a tor node (Nathaniel Mahieu)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8203: Clarify documentation for running a tor node
9e3ec74 Clarify documentation for running a tor node (Nathaniel Mahieu)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8203: Clarify documentation for running a tor node
9e3ec74 Clarify documentation for running a tor node (Nathaniel Mahieu)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8203: Clarify documentation for running a tor node
9e3ec74 Clarify documentation for running a tor node (Nathaniel Mahieu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment