New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] Add a link to the Bitcoin-Core repository and website to the About Dialog #8207

Merged
merged 1 commit into from Jun 16, 2016

Conversation

Projects
None yet
7 participants
@MarcoFalke
Member

MarcoFalke commented Jun 15, 2016

Alternative to #8192

@MarcoFalke MarcoFalke added the Docs label Jun 15, 2016

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Jun 15, 2016

Member

We should also have a link to the project website.

Member

btcdrak commented Jun 15, 2016

We should also have a link to the project website.

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Jun 15, 2016

Member

Perhaps better to just link the website, in case we move off github in the future?

Member

gmaxwell commented Jun 15, 2016

Perhaps better to just link the website, in case we move off github in the future?

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Jun 15, 2016

Member

@gmaxwell agreed. The website address should be more permanent than the source repository which may or may not change in the future.

Member

btcdrak commented Jun 15, 2016

@gmaxwell agreed. The website address should be more permanent than the source repository which may or may not change in the future.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 15, 2016

Member

@btcdrak @gmaxwell I still think it is useful to have a link directly to the GitHub repo. I think there are no plans to move away from GitHub in the near future. Though, we may switch to the bitcoin-core organization some time...

Also, I have added two links to the website.

Member

MarcoFalke commented Jun 15, 2016

@btcdrak @gmaxwell I still think it is useful to have a link directly to the GitHub repo. I think there are no plans to move away from GitHub in the near future. Though, we may switch to the bitcoin-core organization some time...

Also, I have added two links to the website.

@MarcoFalke MarcoFalke changed the title from [trivial] Add a link to the Bitcoin-Core repository to the About Dialog to [trivial] Add a link to the Bitcoin-Core repository and website to the About Dialog Jun 15, 2016

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 15, 2016

Member

utACK

Member

sipa commented Jun 15, 2016

utACK

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 15, 2016

Member

I think listing both the source code and the project website is a good idea.

Member

sipa commented Jun 15, 2016

I think listing both the source code and the project website is a good idea.

@paveljanik

View changes

Show outdated Hide outdated src/init.cpp
@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Jun 15, 2016

Member

fine, but my personal preference would just link to "https://bitcoincore.org" rather than a specific page.

Member

btcdrak commented Jun 15, 2016

fine, but my personal preference would just link to "https://bitcoincore.org" rather than a specific page.

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 15, 2016

Contributor

Yes, just one link please. It would be also nice to not have About windows scrollable because of lot of texts.

Contributor

paveljanik commented Jun 15, 2016

Yes, just one link please. It would be also nice to not have About windows scrollable because of lot of texts.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke
Member

MarcoFalke commented Jun 15, 2016

screenshot from 2016-06-15 14-12-02

@btcdrak

This comment has been minimized.

Show comment
Hide comment
@btcdrak

btcdrak Jun 15, 2016

Member

utACK fa6565d

Member

btcdrak commented Jun 15, 2016

utACK fa6565d

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 15, 2016

Contributor

ACK fa6565d

Contributor

paveljanik commented Jun 15, 2016

ACK fa6565d

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 15, 2016

Contributor

When you are in this file, can you change the http:// to https:// in the MIT link?

Contributor

paveljanik commented Jun 15, 2016

When you are in this file, can you change the http:// to https:// in the MIT link?

@MarcoFalke MarcoFalke added this to the 0.13.0 milestone Jun 15, 2016

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 15, 2016

Member

@paveljanik Please mention this in #8192 (I can't change already translated strings as part of this pull anymore, as we are freezing translations tomorrow)

Member

MarcoFalke commented Jun 15, 2016

@paveljanik Please mention this in #8192 (I can't change already translated strings as part of this pull anymore, as we are freezing translations tomorrow)

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 15, 2016

Contributor

@MarcoFalke ? You have just added the string "Please contribute if you..". So?

Contributor

paveljanik commented Jun 15, 2016

@MarcoFalke ? You have just added the string "Please contribute if you..". So?

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 15, 2016

Member

@paveljanik The problem is with already translated strings. Currently we have 161 project languages (27 without translators) and not even the German translations for 0.12 are fully done.

If you change a translated string, people would need to go through the about ~80 languages where it is already translated and apply the difference. This may or may not happen.

To sum up:

  • Having no translation is better than having no link to our websites at all.
  • Having a slightly outdated translation (e.g. a http link) is better than no translation at all.
Member

MarcoFalke commented Jun 15, 2016

@paveljanik The problem is with already translated strings. Currently we have 161 project languages (27 without translators) and not even the German translations for 0.12 are fully done.

If you change a translated string, people would need to go through the about ~80 languages where it is already translated and apply the difference. This may or may not happen.

To sum up:

  • Having no translation is better than having no link to our websites at all.
  • Having a slightly outdated translation (e.g. a http link) is better than no translation at all.
@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 15, 2016

Contributor

Sure, but in the case of http -> https, we can simply postprocess the transifex files.

Contributor

paveljanik commented Jun 15, 2016

Sure, but in the case of http -> https, we can simply postprocess the transifex files.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 16, 2016

Member

Please squash.
ACK fa6565d2fc9c4cd8eac57915dc8b0aef8176b39c

Member

jonasschnelli commented Jun 16, 2016

Please squash.
ACK fa6565d2fc9c4cd8eac57915dc8b0aef8176b39c

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 16, 2016

Member

@jonasschnelli: Squashed fa6565d into fa58e5e

Member

MarcoFalke commented Jun 16, 2016

@jonasschnelli: Squashed fa6565d into fa58e5e

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 16, 2016

Member

Perhaps better to just link the website, in case we move off github in the future?

In that case we'll just update the software.

Sure, but in the case of http -> https, we can simply postprocess the transifex files.

Unfortunately, no, we can't do that. Postprocessing the ts files is simple, but getting the data back to Transifex without breaking all their metadata is not.

utACK fa58e5e, this seems the best solution for 0.13 as we don't want to break translation strings.

Member

laanwj commented Jun 16, 2016

Perhaps better to just link the website, in case we move off github in the future?

In that case we'll just update the software.

Sure, but in the case of http -> https, we can simply postprocess the transifex files.

Unfortunately, no, we can't do that. Postprocessing the ts files is simple, but getting the data back to Transifex without breaking all their metadata is not.

utACK fa58e5e, this seems the best solution for 0.13 as we don't want to break translation strings.

@laanwj laanwj merged commit fa58e5e into bitcoin:master Jun 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 16, 2016

Merge #8207: [trivial] Add a link to the Bitcoin-Core repository and …
…website to the About Dialog

fa58e5e [doc] Add website links to about dialog (MarcoFalke)

@laanwj laanwj referenced this pull request Jun 16, 2016

Closed

Binary release doesn't make it easy to find the source code #8161

1 of 2 tasks complete

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1606-LicInfo branch Jun 16, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8207: [trivial] Add a link to the Bitcoin-Core repository and …
…website to the About Dialog

fa58e5e [doc] Add website links to about dialog (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8207: [trivial] Add a link to the Bitcoin-Core repository and …
…website to the About Dialog

fa58e5e [doc] Add website links to about dialog (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8207: [trivial] Add a link to the Bitcoin-Core repository and …
…website to the About Dialog

fa58e5e [doc] Add website links to about dialog (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8207: [trivial] Add a link to the Bitcoin-Core repository and …
…website to the About Dialog

fa58e5e [doc] Add website links to about dialog (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment