New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set extra flags for unfiltered DNS seed results #8208

Merged
merged 1 commit into from Jun 16, 2016

Conversation

Projects
None yet
5 participants
@sipa
Member

sipa commented Jun 15, 2016

Since #8083 and #7749 were both merged, any flag set in nRelevantServices would propagate to all CAddress results retrieved from the DNS seed, even if that DNS seed does not support filtering.

Fix this by making the name adaptation function also update the passed in flags.

Furthermore, move that from from DNSSeedData to net. Structs in chainparams should be data only.

@MarcoFalke MarcoFalke added the P2P label Jun 15, 2016

@gmaxwell

This comment has been minimized.

Show comment
Hide comment
@gmaxwell

gmaxwell Jun 15, 2016

Member

utACK

Member

gmaxwell commented Jun 15, 2016

utACK

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 16, 2016

Member

Thanks for fixing.
utACK bc0a895

Member

jonasschnelli commented Jun 16, 2016

Thanks for fixing.
utACK bc0a895

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 16, 2016

Member

utACK bc0a895

Member

laanwj commented Jun 16, 2016

utACK bc0a895

@laanwj laanwj merged commit bc0a895 into bitcoin:master Jun 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 16, 2016

Merge #8208: Do not set extra flags for unfiltered DNS seed results
bc0a895 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8208: Do not set extra flags for unfiltered DNS seed results
bc0a895 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8208: Do not set extra flags for unfiltered DNS seed results
bc0a895 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8208: Do not set extra flags for unfiltered DNS seed results
bc0a895 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8208: Do not set extra flags for unfiltered DNS seed results
bc0a895 Do not set extra flags for unfiltered DNS seed results (Pieter Wuille)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment