New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] mininode: fail on send_message instead of silent return #8214

Merged
merged 1 commit into from Jun 17, 2016

Conversation

Projects
None yet
3 participants
@MarcoFalke
Member

MarcoFalke commented Jun 17, 2016

I think the default behavior should be to fail and not silent return.

(A caller has always the choice to catch in case this is needed anywhere.)

@MarcoFalke MarcoFalke added the Tests label Jun 17, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 17, 2016

Member

I tend to agree, better to be explicit.

ACK if this passes travis.

Member

laanwj commented Jun 17, 2016

I tend to agree, better to be explicit.

ACK if this passes travis.

@sdaftuar

This comment has been minimized.

Show comment
Hide comment
@sdaftuar

sdaftuar Jun 17, 2016

Member

Agreed, utACK

Member

sdaftuar commented Jun 17, 2016

Agreed, utACK

@MarcoFalke MarcoFalke merged commit facb6c0 into bitcoin:master Jun 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Jun 17, 2016

Merge #8214: [qa] mininode: fail on send_message instead of silent re…
…turn

facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1606-qaMininodeAssert branch Jun 17, 2016

codablock added a commit to codablock/dash that referenced this pull request Sep 16, 2017

Merge #8214: [qa] mininode: fail on send_message instead of silent re…
…turn

facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8214: [qa] mininode: fail on send_message instead of silent re…
…turn

facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8214: [qa] mininode: fail on send_message instead of silent re…
…turn

facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8214: [qa] mininode: fail on send_message instead of silent re…
…turn

facb6c0 [qa] mininode: fail on send_message instead of silent return (MarcoFalke)

@dagurval dagurval referenced this pull request Feb 1, 2018

Merged

QA cherries #319

sickpig added a commit to sickpig/BitcoinUnlimited that referenced this pull request Mar 12, 2018

Partial port of XT PR #319 from dagurval/qa-cherries
Core QA cherries

bitcoin/bitcoin#8047 - [qa] test_framework: Set wait-timeout for bitcoind procs
bitcoin/bitcoin#8095 - Test framework: only cleanup on successful test runs
bitcoin/bitcoin#8214 - [qa] mininode: fail on send_message instead of silent return

@sickpig sickpig referenced this pull request Mar 12, 2018

Merged

QA Core ports #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment