Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qa] assert 'changePosition out of bounds' #8216

Merged
merged 4 commits into from Jun 21, 2016

Conversation

@MarcoFalke
Copy link
Member

commented Jun 17, 2016

This was previously untested.

Also includes two refactoring commits.

@MarcoFalke MarcoFalke added the Tests label Jun 17, 2016

@laanwj

This comment has been minimized.

Copy link
Member

commented Jun 20, 2016

utACK fa3b379

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2016

Added another refactoring commit:

  • Start p2p-fullblocktest first to give running tests in parallel an advantage

(Sorry for hijacking this pull for trivial fixups, but I think it is not worth to create a pull for every commit)

@laanwj

This comment has been minimized.

Copy link
Member

commented Jun 21, 2016

re-utACK fa58f94

@laanwj laanwj merged commit fa58f94 into bitcoin:master Jun 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
laanwj added a commit that referenced this pull request Jun 21, 2016
Merge #8216: [qa] assert 'changePosition out of bounds'
fa58f94 [qa] pull-tester: Start longest test first (MarcoFalke)
fa3b379 [qa] pull-tester: Fix assertion and check for run_parallel (MarcoFalke)
fa32465 [qa] fundrawtransaction: Create get_unspent() (MarcoFalke)
fa8ce3b [qa] assert 'changePosition out of bounds' (MarcoFalke)

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1606-qaFundrawtransaction branch Jun 21, 2016

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017
Merge bitcoin#8216: [qa] assert 'changePosition out of bounds'
fa58f94 [qa] pull-tester: Start longest test first (MarcoFalke)
fa3b379 [qa] pull-tester: Fix assertion and check for run_parallel (MarcoFalke)
fa32465 [qa] fundrawtransaction: Create get_unspent() (MarcoFalke)
fa8ce3b [qa] assert 'changePosition out of bounds' (MarcoFalke)
andvgal added a commit to energicryptocurrency/energi that referenced this pull request Jan 6, 2019
Merge bitcoin#8216: [qa] assert 'changePosition out of bounds'
fa58f94 [qa] pull-tester: Start longest test first (MarcoFalke)
fa3b379 [qa] pull-tester: Fix assertion and check for run_parallel (MarcoFalke)
fa32465 [qa] fundrawtransaction: Create get_unspent() (MarcoFalke)
fa8ce3b [qa] assert 'changePosition out of bounds' (MarcoFalke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.