New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] fix a bug where the SplashScreen will not be hidden during startup #8231

Merged
merged 1 commit into from Jun 22, 2016

Conversation

Projects
None yet
2 participants
@jonasschnelli
Member

jonasschnelli commented Jun 21, 2016

Fixes #7718

I guess calling QWidget::hide() on a QWidget::isMinimized() will not always result in a hidden window.
It's hard to say if this is a bug or a feature.

This little PR will make sure, we de-minimize the splashscreen-window before hiding.

@jonasschnelli jonasschnelli added the GUI label Jun 21, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 21, 2016

Member

Though this doesn't hurt, this sounds like an upstream Qt bug to me. Hide should hide no matter what the other window flags are.

Does this happen with all Qt versions?

Member

laanwj commented Jun 21, 2016

Though this doesn't hurt, this sounds like an upstream Qt bug to me. Hide should hide no matter what the other window flags are.

Does this happen with all Qt versions?

@laanwj

View changes

Show outdated Hide outdated src/qt/splashscreen.cpp
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 21, 2016

Member

I haven't looked at the Qt code. But I could understand the argument that a minimized window is hidden fro the user perspective (but not closed). For the API perspective, I guess we should do a showNormal() before hide().

Member

jonasschnelli commented Jun 21, 2016

I haven't looked at the Qt code. But I could understand the argument that a minimized window is hidden fro the user perspective (but not closed). For the API perspective, I guess we should do a showNormal() before hide().

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 21, 2016

Member

Added a comment.

Member

jonasschnelli commented Jun 21, 2016

Added a comment.

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 21, 2016

Member

But I could understand the argument that a minimized window is hidden fro the user perspective (but not closed)

But at least up until now, in Qt, hidden really meant hidden. As in: seem closed and be complete inaccessible from the user perspective. A lot of code relies on that being the case.

I'm kind of disappointed about Qt if this is on purpose. Managing window state becomes more and more complex (see how many of the lines of bitcoingui.cpp are spent on just that...).

Member

laanwj commented Jun 21, 2016

But I could understand the argument that a minimized window is hidden fro the user perspective (but not closed)

But at least up until now, in Qt, hidden really meant hidden. As in: seem closed and be complete inaccessible from the user perspective. A lot of code relies on that being the case.

I'm kind of disappointed about Qt if this is on purpose. Managing window state becomes more and more complex (see how many of the lines of bitcoingui.cpp are spent on just that...).

@laanwj laanwj merged commit b3e1348 into bitcoin:master Jun 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jun 22, 2016

Merge #8231: [Qt] fix a bug where the SplashScreen will not be hidden…
… during startup

b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli)
@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 22, 2016

Member

utACK b3e1348

Member

laanwj commented Jun 22, 2016

utACK b3e1348

codablock added a commit to codablock/dash that referenced this pull request Sep 7, 2017

Merge #8231: [Qt] fix a bug where the SplashScreen will not be hidden…
… during startup

b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli)

UdjinM6 added a commit to dashpay/dash that referenced this pull request Sep 9, 2017

Backport Bitcoin Qt/Gui changes up to 0.14.x part 2 (#1615)
* Merge #7506: Use CCoinControl selection in CWallet::FundTransaction

d6cc6a1 Use CCoinControl selection in CWallet::FundTransaction (João Barbosa)

* Merge #7732: [Qt] Debug window: replace "Build date" with "Datadir"

fc737d1 [Qt] remove unused formatBuildDate method (Jonas Schnelli)
4856f1d [Qt] Debug window: replace "Build date" with "Datadir" (Jonas Schnelli)

* Merge #7707: [RPC][QT] UI support for abandoned transactions

8efed3b [Qt] Support for abandoned/abandoning transactions (Jonas Schnelli)

* Merge #7688: List solvability in listunspent output and improve help

c3932b3 List solvability in listunspent output and improve help (Pieter Wuille)

* Merge #8006: Qt: Add option to disable the system tray icon

8b0e497 Qt: Add option to hide the system tray icon (Tyler Hardin)

* Merge #8073: qt: askpassphrasedialog: Clear pass fields on accept

02ce2a3 qt: askpassphrasedialog: Clear pass fields on accept (Pavel Vasin)

* Merge #8231: [Qt] fix a bug where the SplashScreen will not be hidden during startup

b3e1348 [Qt] fix a bug where the SplashScreen will not be hidden during startup (Jonas Schnelli)

* Merge #8257: Do not ask a UI question from bitcoind

1acf1db Do not ask a UI question from bitcoind (Pieter Wuille)

* Merge #8463: [qt] Remove Priority from coincontrol dialog

fa8dd78 [qt] Remove Priority from coincontrol dialog (MarcoFalke)

* Merge #8678: [Qt][CoinControl] fix UI bug that could result in paying unexpected fee

0480293 [Qt][CoinControl] fix UI bug that could result in paying unexpected fee (Jonas Schnelli)

* Merge #8672: Qt: Show transaction size in transaction details window

c015634 qt: Adding transaction size to transaction details window (Hampus Sjöberg)
 \-- merge fix for s/size/total size/
fdf82fb Adding method GetTotalSize() to CTransaction (Hampus Sjöberg)

* Merge #8371: [Qt] Add out-of-sync modal info layer

08827df [Qt] modalinfolayer: removed unused comments, renamed signal, code style overhaul (Jonas Schnelli)
d8b062e [Qt] only update "amount of blocks left" when the header chain is in-sync (Jonas Schnelli)
e3245b4 [Qt] add out-of-sync modal info layer (Jonas Schnelli)
e47052f [Qt] ClientModel add method to get the height of the header chain (Jonas Schnelli)
a001f18 [Qt] Always pass the numBlocksChanged signal for headers tip changed (Jonas Schnelli)
bd44a04 [Qt] make Out-Of-Sync warning icon clickable (Jonas Schnelli)
0904c3c [Refactor] refactor function that forms human readable text out of a timeoffset (Jonas Schnelli)

* Merge #8805: Trivial: Grammar and capitalization

c9ce17b Trivial: Grammar and capitalization (Derek Miller)

* Merge #8885: gui: fix ban from qt console

cb78c60 gui: fix ban from qt console (Cory Fields)

* Merge #8821: [qt] sync-overlay: Don't block during reindex

fa85e86 [qt] sync-overlay: Don't show estimated number of headers left (MarcoFalke)
faa4de2 [qt] sync-overlay: Don't block during reindex (MarcoFalke)

* Support themes for new transaction_abandoned icon

* Fix constructor call to COutput

* Merge #7842: RPC: do not print minping time in getpeerinfo when no ping received yet

62a6486 RPC: do not print ping info in getpeerinfo when no ping received yet, fix help (Pavel Janík)

* Merge #8918: Qt: Add "Copy URI" to payment request context menu

21f5a63 Qt: Add "Copy URI" to payment request context menu (Luke Dashjr)

* Merge #8925: qt: Display minimum ping in debug window.

1724a40 Display minimum ping in debug window. (R E Broadley)

* Merge #8972: [Qt] make warnings label selectable (jonasschnelli)

ef0c9ee [Qt] make warnings label selectable (Jonas Schnelli)

* Make background of warning icon transparent in modaloverlay

* Merge #9088: Reduce ambiguity of warning message

77cbbd9 Make warning message about wallet balance possibly being incorrect less ambiguous. (R E Broadley)

* Replace Bitcoin with Dash in modal overlay

* Remove clicked signals from labelWalletStatus and labelTransactionsStatus

As both are really just labels, clicking on those is not possible.
This is different in Bitcoin, where these labels are actually buttons.

* Pull out modaloverlay show/hide into it's own if/else block and switch to time based check

Also don't use masternodeSync.IsBlockchainSynced() for now as it won't
report the blockchain being synced before the first block (or other MN
data?) arrives. This would otherwise give the impression that sync is
being stuck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment