New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary LOCK(cs_main) in getrawpmempool #8244

Merged
merged 1 commit into from Jun 25, 2016

Conversation

Projects
None yet
6 participants
@dcousens
Contributor

dcousens commented Jun 23, 2016

I'm happy to be wrong, but I can't see why this is necessary, especially when the mempool locks are all in place in subsequent functions?

@dcousens dcousens changed the title from remove unnecessary LOCK(cs_main) to remove unnecessary LOCK(cs_main) in getrawpmempool Jun 23, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 23, 2016

Member

I think you are right.
utACK 27f8126

Member

laanwj commented Jun 23, 2016

I think you are right.
utACK 27f8126

@laanwj laanwj added the RPC/REST/ZMQ label Jun 23, 2016

@paveljanik

This comment has been minimized.

Show comment
Hide comment
@paveljanik

paveljanik Jun 23, 2016

Contributor

utACK 27f8126

Contributor

paveljanik commented Jun 23, 2016

utACK 27f8126

@pstratem

This comment has been minimized.

Show comment
Hide comment
@pstratem

pstratem Jun 23, 2016

Contributor

utACK 27f8126

Contributor

pstratem commented Jun 23, 2016

utACK 27f8126

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake
Member

fanquake commented Jun 24, 2016

utACK 27f8126

@sipa

This comment has been minimized.

Show comment
Hide comment
@sipa

sipa Jun 24, 2016

Member

utACK 27f8126

Member

sipa commented Jun 24, 2016

utACK 27f8126

@laanwj laanwj merged commit 27f8126 into bitcoin:master Jun 25, 2016

laanwj added a commit that referenced this pull request Jun 25, 2016

Merge #8244: remove unnecessary LOCK(cs_main) in getrawpmempool
27f8126 remove unnecessary LOCK(cs_main) (Daniel Cousens)

@dcousens dcousens deleted the dcousens:patch-1 branch Jun 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment