New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: bitcoin-qt crash #8256

Merged
merged 1 commit into from Jun 24, 2016

Conversation

Projects
None yet
4 participants
@fsb4000
Contributor

fsb4000 commented Jun 24, 2016

How to reproduce bug:

  1. Run bitcoin-qt which doen't have transactions. (any mode, here testnet screenshot but same problem with mainnet)
    Image of first step
  2. Press right mouse button at center:
    Image of second step
  3. Program crashes:
    Image of third step

I found that error at the line:

hash.SetHex(selection.at(0).data(TransactionTableModel::TxHashRole).toString().toStdString());

and I added the check.

My system: Linux Mint 18, Qt 5.5

@laanwj laanwj added GUI Bug labels Jun 24, 2016

@laanwj

This comment has been minimized.

Show comment
Hide comment
@laanwj

laanwj Jun 24, 2016

Member

Good catch!
I take it that "АВарийный останов" is a "Segmentation Fault" in Russian (Google translates it as "Emergency Stop")?
utACK 59b861b

Member

laanwj commented Jun 24, 2016

Good catch!
I take it that "АВарийный останов" is a "Segmentation Fault" in Russian (Google translates it as "Emergency Stop")?
utACK 59b861b

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Jun 24, 2016

Member

Concept ACK. Thanks for adding steps to reproduce!

Member

MarcoFalke commented Jun 24, 2016

Concept ACK. Thanks for adding steps to reproduce!

@laanwj

View changes

Show outdated Hide outdated src/qt/transactionview.cpp
@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Jun 24, 2016

Member

Thanks. Seems necessary.
utACK d7828ab.

Member

jonasschnelli commented Jun 24, 2016

Thanks. Seems necessary.
utACK d7828ab.

@laanwj laanwj merged commit d7828ab into bitcoin:master Jun 24, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

laanwj added a commit that referenced this pull request Jun 24, 2016

Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

codablock added a commit to codablock/dash that referenced this pull request Sep 19, 2017

Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Dec 20, 2017

Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

UdjinM6 added a commit to dashpay/dash that referenced this pull request Dec 21, 2017

Merge #8256: BUG: bitcoin-qt crash (#1800)
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Dec 26, 2017

Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Dec 26, 2017

Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

codablock added a commit to codablock/dash that referenced this pull request Dec 27, 2017

Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

codablock added a commit to codablock/dash that referenced this pull request Dec 28, 2017

Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

sidhujag added a commit to syscoin/syscoin that referenced this pull request Jan 2, 2018

Merge #8256: BUG: bitcoin-qt crash (#1800)
But fix properly, bitcoin upstream did not fix properly

UdjinM6 added a commit to UdjinM6/dash that referenced this pull request Jan 5, 2018

Merge #8256: BUG: bitcoin-qt crash
d7828ab check that transactionView->selectionModel()->selectedRows(0) exists (fsb4000)

NarubyRiverlione added a commit to NarubyRiverlione/spice that referenced this pull request Feb 4, 2018

Merge branch 'spice' of github.com:NarubyRiverlione/spice into spice
* 'spice' of github.com:NarubyRiverlione/spice: (8382 commits)
  updated testnet genessis
  spice images
  more rename
  genesis blocks ports magic message letters start letter addresses
  cleanup : * remove gitian signatures * remove seeds
  rename: more originale files
  rename
  Prepare 0.12.2.3 release notes (#1846)
  Avoid reference leakage in CKeyHolderStorage::AddKey (#1840)
  Protect CKeyHolderStorage via mutex (#1834)
  Skip existing masternode conections on mixing (#1833)
  Merge pull request #1836 from lodgepole/feature/backport-11847
  Fix -liquidityprovider option (#1829)
  Vote on IS only if it was accepted to mempool (#1826)
  bump version to 0.12.2.3 (#1827)
  Merge #8256: BUG: bitcoin-qt crash
  Swap iterations and fUseInstantSend parameters in ApproximateBestSubset (#1819)
  Fix crash on exit when -createwalletbackups=0 (#1810)
  Prepare v0.12.2.2 release notes (#1769)
  Force rcc to use resource format version 1. (#1784)
  ...

# Conflicts:
#	contrib/gitian-descriptors/gitian-osx-signer.yml
#	contrib/gitian-descriptors/gitian-win-signer.yml
#	src/chainparams.cpp
#	src/qt/res/icons/bitcoin.icns
#	src/qt/res/icons/bitcoin.ico
#	src/qt/res/icons/bitcoin.png
#	src/qt/res/icons/crownium/about.png
#	src/qt/res/icons/drkblue/about.png
#	src/qt/res/icons/drkblue/bitcoin.png
#	src/qt/res/icons/light/about.png
#	src/qt/res/icons/light/remove.png
#	src/qt/res/icons/remove.png
#	src/qt/res/icons/trad/about.png
#	src/qt/res/icons/trad/remove.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment